Fix: Prevent app crash during colony creation #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubcolony
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
What a turnaround, nice job fixing this @rumzledz! 🔧
Screen.Recording.2025-01-13.at.19.21.51.mov
rdig
approved these changes
Jan 13, 2025
iamsamgibbs
approved these changes
Jan 13, 2025
rumzledz
deleted the
fix/4083-prevent-app-crash-during-colony-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The app was crashing because the GroupedTransaction component is attempting to access the Colony Context before the app even navigates to a Colony. I slightly tweaked the logic to make sure this doesn't happen.
Testing
node scripts/create-colony-url.jsResolves #4083