fix: dont show staking errors if the motion is completed

[bassgeta]

Description

This PR just cleans up the booleans a bit and makes sure that when a motion is completed, the errors don't show up.

Testing

1. Run your dev env and the create-data script, install the voting reputation extension in planex
2. Open up 2 more browsers (trust me, it's gonna be the fastest).
3. Be logged in as leela in browser 1. In browser 2, go to http://localhost:9091/go/planex with Dev wallet 4. Name the user "has-nothing" or something
   
4. In browser 2, go to http://localhost:9091/go/planex with Dev wallet 5. Name the user "has-no-coins"
   
5. Run the following query and copy the invite code.

query MyQuery {
  getColony(id: "<planex_address>") {
    colonyMemberInviteCode
  }
}

6. Open up the URL http://localhost:9091/invite/planex/<that_code> as has-nothing and has-no-coins and join the colony
7. As leela give has-no-coins some reputation in General. Go to http://localhost:3001/reputation/monitor/toggle and run npm run forward-time 1 in the terminal

8. Create a mint tokens motion and fully stake it as leela. Don't finalize it!

9. As has-nothing open up the motion and verify that you get the no reputation error.

10. As has-no-coins open up the motion and verify that you get the not enough tokens error.

11. Finalize the motion and open it as has-nothing and has-no-coins and verify that there is no error

Diffs

Changes 🏗

• Tidied up the boolean flags in StakingStep

Resolves #3909

[rumzledz]

You gotta love these motion quirks 😄

Created has-nothing & has-no-coins

Create and support Mint Motion as leela

has-nothing error

has-no-coins error

Finalised motion as leela

No more errors for has-nothing & has-no-coins

[rdig]

All good here

[mmioana]

This is such a nice and straight-forward fix @bassgeta 🎉

Created the two users and joined planex

Gave no-coins some reputation

Created a Mint tokens motion and went through the whole staking and voting process as leela

The right errors showed up before the motion finalisation

And no longer showed up after the motion was finalised

And tested also for a motion going only through staking

Nice job!!! 💯