Remove deprecated functions

[area]

For a while, we've been marking functions as deprecated, and not doing anything further.

The crows have come home to roost.

Ready for review, I reckon, but not to merge - both because of the upcoming release, and because this will need testing against the dapp and the cdapp to make sure they're not using anything that we're removing, and then having those updated accordingly.

The functions removed are as follows:

• makeArbitraryTransactions
• makeSingleArbitraryTransaction
• transferExpenditureViaArbitration
• setExpenditureRecipient
• setExpenditurePayout
• setExpenditureSkill
• setExpenditureClaimDelay
• moveFundsBetweenPots (old signature)

In addition, makeArbitraryTransaction gains a new _strict argument

[kronosapiens]

Starting documenting the testing & any errors I see.

1. When attempting to transfer funds from the root to a child domain (using the old moveFundsBetweenPots?):

Retrying RPC request # 10 Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="Error: Transaction reverted without a reason string", method="estimateGas", transaction={"from":"0xb77D57F4959eAfA0339424b83FcFaf9c15407461","to":"0x3dd1ce7168565AB572320B1794bEb0c2E28975eC","data":"0xc68d19ea0000000000000000000000000000000000000000000000000000000000000001ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000152d02c7e14af6800000000000000000000000000000ef841fe1611ce41bfcf0265097efaf50486f5111","accessList":null}, error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":98,\"error\":{\"code\":-32603,\"message\":\"Error: Transaction reverted without a reason string\",\"data\":{\"message\":\"Error: Transaction reverted without a reason string\",\"data\":\"0x\"}}}","error":{"code":-32603,"data":{"message":"Error: Transaction reverted without a reason string","data":"0x"}},"requestBody":"{\"method\":\"eth_estimateGas\",\"params\":[{\"from\":\"0xb77d57f4959eafa0339424b83fcfaf9c15407461\",\"to\":\"0x3dd1ce7168565ab572320b1794beb0c2e28975ec\",\"data\":\"0xc68d19ea0000000000000000000000000000000000000000000000000000000000000001ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000152d02c7e14af6800000000000000000000000000000ef841fe1611ce41bfcf0265097efaf50486f5111\"}],\"id\":98,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"http://localhost:8545"}, code=UNPREDICTABLE_GAS_LIMIT, version=providers/5.7.1)
    at _Logger.makeError (chunk-TIQWD657.js?v=d98bc71d:212:23)
    at _Logger.throwError (chunk-TIQWD657.js?v=d98bc71d:221:20)
    at checkError (chunk-GR63E4DI.js?v=d98bc71d:3647:15)
    at RetryRpcProvider.<anonymous> (chunk-GR63E4DI.js?v=d98bc71d:4176:20)
    at Generator.throw (<anonymous>)
    at rejected (chunk-GR63E4DI.js?v=d98bc71d:3755:36)

2. Simple payment SUCCEEDS

3. Advanced payment (2 recipients) SUCCEEDS

4. Split payment (3 recipients) SUCCEEDS

5. Creating a payment via a motion logs this error to the console during staking:

intl.ts:108 Error: [@formatjs/intl Error FORMAT_ERROR] Error formatting message: "action.title", using id as fallback.
MessageID: action.title
Default Message: undefined
Description: undefined

Locale: en


The intl string context variable "recipient" was not provided to the string "undefined"
Error: The intl string context variable "recipient" was not provided to the string "undefined"

6. Create domain SUCCEEDS
7. Whitelisting a new token SUCCEEDS

Note -- there does not seem to be any way to test transferExpenditureViaArbitration in the current UX

[kronosapiens]

Note that the commit hash for shoving the version numbers is here:

68f68d4

[kronosapiens]

Front-end changes being tracked here: JoinColony/colonyCDapp#3820