[Request] load bitcoind wallet before interaction #812
Comments
|
This will not be hard to implement, only question is aren't there any objections to do this for some reason? |
|
@kristapsk it seems there are no objections :) |
|
Ok, will look into this. |
nixbitcoin
added a commit
to nixbitcoin/nix-bitcoin
that referenced
this issue
Jul 8, 2021
Includes - coincurve: 13.0.0 -> 15.0.0 - Darkscience Tor onion address update - bitcoin-cli jm_wallet generation - don't copy bitcoin-rpcpassword-privileged as privileged user, instead add the joinmarket user to bitcoin group. Same effect, less complexity. Note, PoLP still obeyed for joinmarket-ob-watcher. Starting with 0.21.0, [bitcoin no longer automatically creates and loads a default wallet](bitcoin/bitcoin#15454). This was being ignored because of [a JoinMarket issue]( JoinMarket-Org/joinmarket-clientserver#812) in CI builds prior to this version. Now a watch-only Bitcoin Core wallet is created in the ExecStartPost.
nixbitcoin
added a commit
to nixbitcoin/nix-bitcoin
that referenced
this issue
Jul 12, 2021
Includes - coincurve: 13.0.0 -> 15.0.0 - Darkscience Tor onion address update - bitcoin-cli jm_wallet generation - don't copy bitcoin-rpcpassword-privileged as privileged user, instead add the joinmarket user to bitcoin group. Same effect, less complexity. Note, PoLP still obeyed for joinmarket-ob-watcher. Starting with 0.21.0, [bitcoin no longer automatically creates and loads a default wallet](bitcoin/bitcoin#15454). This was being ignored because of [a JoinMarket issue]( JoinMarket-Org/joinmarket-clientserver#812) in CI builds prior to this version. Now a watch-only Bitcoin Core wallet is created in the ExecStartPost.
erikarvstedt
pushed a commit
to erikarvstedt/nix-bitcoin
that referenced
this issue
Aug 8, 2021
Starting with 0.21.0, bitcoin no longer automatically creates and loads a default wallet. This was being ignored because of a JoinMarket issue [1] in CI builds prior to this version. Now a watch-only Bitcoin Core wallet is created in ExecStartPost. [1] JoinMarket-Org/joinmarket-clientserver#812
erikarvstedt
pushed a commit
to erikarvstedt/nix-bitcoin
that referenced
this issue
Aug 8, 2021
Starting with 0.21.0, bitcoin no longer automatically creates and loads a default wallet. This was being ignored because of a JoinMarket issue [1] in CI builds prior to this version. Now a watch-only Bitcoin Core wallet is created in ExecStartPost. [1] JoinMarket-Org/joinmarket-clientserver#812
nixbitcoin
added a commit
to nixbitcoin/nix-bitcoin
that referenced
this issue
Aug 10, 2021
Starting with 0.21.0, bitcoin no longer automatically creates and loads a default wallet. This was being ignored because of a JoinMarket issue [1] in CI builds prior to this version. Now a watch-only Bitcoin Core wallet is created in ExecStartPost. [1] JoinMarket-Org/joinmarket-clientserver#812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a recommendation in the readme: about using a dedicated bitcoind wallet for JoinMarket: https://github.com/JoinMarket-Org/joinmarket-clientserver/blob/master/docs/USAGE.md#setting-a-core-wallet-recommended which is good practice, but requires bitcoind to manage multiple wallets, especially running alongside software using watch only wallets as well like Specter Desktop.
This causes issues for users when other (than the default) wallet is loaded or when the wallet was loaded, but the bitcoin node restarts.
It could be beneficial for JM to check and load the
rpc_walletspecified in thejoinmarket.cfgbefore interaction to avoid the error:"wallet does not exist or is not loaded" .
edit: It might make sense to use
createwalletas well in case the wallet is not present on bitcoind yet. Would that cause any concerns?The text was updated successfully, but these errors were encountered: