-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry #17
Open
ghost
wants to merge
83
commits into
JonathanBennett:master
Choose a base branch
from
akamai:retry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Retry #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rately reflects the naming conventions used by Akamai. Updated the README to list preferred method as using an .edgerc file and other addendums.
…ile in the package. Updated tests to reflect new section updates.
…and contributors.
Per conversation with @ktyacke and @JonathanBennett, 2 space indentation is the preferred standard in AkamaiOPEN-edgegrid-node
Per conversation with @ktyacke and @JonathanBennett, 2 space indentation is the preferred standard in AkamaiOPEN-edgegrid-node
Code style cleanup
Per Akamai API authentication documentation: - there is no need to specify specific headers to sign; all can/should be signed, which simplifies the code - there is no need to order the canonicalized headers See documentation for further clarification: https://developer.akamai.com/introduction/Client_Auth.html
simplify header canonicalization
… 200000 bytes to meet the update max-body value of 131072.
…d which is now stripped from the string.
Headers to sign
… is found, auth will handle converting it to a JSON string which will properly match the body signature. Updated tests to correspond with the new api updates.d
Headers to sign
…nd using the debug option.
Make auth() in api.js chainable
fix throw inside an async method
Update uuid to version 3.0.0
Updates requests to 2.74.0 to skip vulnerability issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding retry functionality for responses with a 500 error.