Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonic yearly_average #188

Merged
merged 45 commits into from
Nov 26, 2024
Merged

Pythonic yearly_average #188

merged 45 commits into from
Nov 26, 2024

Conversation

JoranAngevaare
Copy link
Owner

@JoranAngevaare JoranAngevaare commented Sep 2, 2024

Pythonic yearly_average

Add a simple yearly averaging function that takes into account the different weights of months.

Since this is such a simple and common application, I've tried out using ChatGPT to improve/expand and test the initial idea 94aa890.

Todo

To make this PR complete:

  • Add test
  • Write documentation on required datafmt

@coveralls
Copy link

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 12028286009

Details

  • 30 of 34 (88.24%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 87.861%

Changes Missing Coverage Covered Lines Changed/Added Lines %
optim_esm_tools/analyze/xarray_tools.py 30 34 88.24%
Files with Coverage Reduction New Missed Lines %
optim_esm_tools/analyze/xarray_tools.py 1 82.86%
Totals Coverage Status
Change from base Build 12026485221: 0.006%
Covered Lines: 2070
Relevant Lines: 2356

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 10664936256

Details

  • 1 of 40 (2.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 86.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
optim_esm_tools/analyze/xarray_tools.py 1 40 2.5%
Totals Coverage Status
Change from base Build 10662778224: -1.5%
Covered Lines: 1992
Relevant Lines: 2303

💛 - Coveralls

JoranAngevaare and others added 23 commits September 4, 2024 13:20
@JoranAngevaare JoranAngevaare marked this pull request as ready for review September 4, 2024 13:17
@JoranAngevaare JoranAngevaare merged commit 93aa3d0 into master Nov 26, 2024
13 checks passed
@JoranAngevaare JoranAngevaare deleted the Pythonic-yearly_average branch November 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants