Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge adjacent candidates #199

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Merge adjacent candidates #199

merged 8 commits into from
Nov 26, 2024

Conversation

JoranAngevaare
Copy link
Owner

Merge adjacent candidates

In this PR, we add a feature to keep merging a set of candidates, so long as their properties are consistent with a predefined yes/no criterion.

Testing

Is rather rudimentary and auto-generated with ChatGPT, a more extensive set of tests would be advisable.

@coveralls
Copy link

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12033286069

Details

  • 215 of 231 (93.07%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 88.288%

Changes Missing Coverage Covered Lines Changed/Added Lines %
optim_esm_tools/analyze/merge_candidate_regions.py 214 230 93.04%
Totals Coverage Status
Change from base Build 12028974447: 0.4%
Covered Lines: 2284
Relevant Lines: 2587

💛 - Coveralls

@JoranAngevaare JoranAngevaare marked this pull request as ready for review November 26, 2024 15:23
@JoranAngevaare JoranAngevaare merged commit fdef3b1 into master Nov 26, 2024
13 checks passed
@JoranAngevaare JoranAngevaare deleted the merge_adjacent branch November 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants