Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region calculation #201

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Region calculation #201

merged 10 commits into from
Nov 27, 2024

Conversation

JoranAngevaare
Copy link
Owner

Region calculation

Calculate essential properties of a region for a set of:

  • a dataset
  • the corresponding PiControl dataset
  • a region of interest

These properties are re-used to asses the if the region is of particular interest

Testing is lacking

Has to be implemented in a future PR

@coveralls
Copy link

coveralls commented Nov 26, 2024

Pull Request Test Coverage Report for Build 12056377112

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 110 of 393 (27.99%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-7.0%) to 76.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
optim_esm_tools/plotting/plot_utils.py 53 56 94.64%
optim_esm_tools/analyze/merge_candidate_regions.py 3 10 30.0%
optim_esm_tools/utils.py 1 10 10.0%
optim_esm_tools/analyze/region_calculation.py 49 313 15.65%
Files with Coverage Reduction New Missed Lines %
optim_esm_tools/utils.py 2 80.95%
Totals Coverage Status
Change from base Build 12035661708: -7.0%
Covered Lines: 2368
Relevant Lines: 3086

💛 - Coveralls

@JoranAngevaare JoranAngevaare marked this pull request as ready for review November 27, 2024 09:34
@JoranAngevaare JoranAngevaare merged commit 15310d4 into master Nov 27, 2024
6 of 11 checks passed
@JoranAngevaare JoranAngevaare deleted the region_calculation branch November 27, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants