Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two finger pinch is often mis-recognised as two finger swipe. #541

Closed
dreirund opened this issue Oct 20, 2021 · 6 comments · Fixed by #544
Closed

Two finger pinch is often mis-recognised as two finger swipe. #541

dreirund opened this issue Oct 20, 2021 · 6 comments · Fixed by #544
Labels
Milestone

Comments

@dreirund
Copy link

dreirund commented Oct 20, 2021

Describe the bug

Two finger pinch is easily misinterpreted as two finger swipe.

Expected behaviour

Make it easier to issue pinch gestures.

Looks like pinch recognition is too "strict".

Make a pinch if the relative distance between the fingers, or the angle of the line between the fingers, changes significantly, also if one finger does not move much absolutely.

Best: Add configuration items on thresholds to tell pinch and swipe apart.

Actual behaviour

I have two finger pinch and two finger swipe gestures configured. However, if I want to pinch, very easily touchegg does a swipe instead.

For three fingers this problem also appears, but less often.

I had the impression that with Touchégg version 1 it was much easier to actually trigger a two finger pinch correctly while also beeing able to trigger two finger swipe.

I use a touchscreen, not a touchpad. It is often just not easy to move both fingers at the same speed in opposite directions; often one finger does not move much but the other does.

Your environment

  • Version of Touchégg: Run touchegg --version in the terminal to check the version: Touchégg v2.0.11..
  • Operating System: Ubuntu, Fedora, Arch Linux...: Artix GNU/Linux.
  • Desktop Environment: Gnome, KDE, Xfce...: No full blown desktop environment. Standalone window manager: xfwm4 or openbox; standalone Panels: xfce4-panel.
  • Multitouch device: Lenovo m14t touchscreen.
@JoseExposito
Copy link
Owner

I just released v2.0.12 including improvements on pinch detection.

Once it is available for your distro, could you test if the new version improved 2 finger pinch detection, please?

If not, a libinput record will help me to reproduce the issue locally. In order to generate one, execute this command:

$ sudo libinput record > recording.yml

And perform a pinch gesture. If the pinch is buggy, press control+C and attach the file here. Otherwise, press control+C and restart the command to keep the log as short as possible.

@dreirund
Copy link
Author

I just released v2.0.12 including improvements on pinch detection.

Once it is available for your distro,

I just made it available for myself

could you test if the new version improved 2 finger pinch detection, please?

It does not look better.

If not, a libinput record will help me to reproduce the issue locally.

Here I attach the following:

Does that help?

@JoseExposito
Copy link
Owner

Yes, thanks for the logs. There was a problem detecting pinch gestures when the fingers are placed horizontally or vertically.

Could you test this PR to discard any further issues, please? #544

@JoseExposito JoseExposito added this to the 2.0.13 milestone Oct 24, 2021
@dreirund
Copy link
Author

dreirund commented Oct 24, 2021 via email

JoseExposito added a commit that referenced this issue Oct 25, 2021
@JoseExposito
Copy link
Owner

Sure, I merged the lock file fix to simplify things a bit. Since you were using PKGBUILD to install the latest release, you should be able to change the source to point to the pull request branch:

source=("${_pkgname}::git+https://github.com/JoseExposito/touchegg.git#branch=issue-541")

Borrowed that like from AUR touchegg-git.

@dreirund
Copy link
Author

dreirund commented Oct 26, 2021 via email

JoseExposito added a commit that referenced this issue Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants