Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print all printed value that includes new lines characters #193

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Print all printed value that includes new lines characters #193

merged 1 commit into from
Mar 7, 2023

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Mar 5, 2023 •
edited
Loading

PR Checklist

Overview

if the issue is rejected, please close this PR.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 7, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in! LGTM ✅

There is some value in concatenating the long lines. But I think there'd need to be some thought put into how to do that in a way that doesn't omit information by default.

@JoshuaKGoldberg JoshuaKGoldberg merged commit e7ef8d3 into JoshuaKGoldberg:main Mar 7, 2023
@sosukesuzuki sosukesuzuki deleted the avoid-omit branch March 8, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: avoid omission for new lines
2 participants
@sosukesuzuki @JoshuaKGoldberg