fix: only update type snapshots if process.argv includes --fix #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Only adds a
fix()
function ifprocess.argv.includes("--fix")
. This will therefore stop type snapshots from being updated automatically when ESLint is run through the Node API, such as in an editor extension.This is the best I can do without ESLint providing a native way for rules to know whether they're in fix mode 😬. I don't like it. It's a rough heuristic and I'll file a followup issue on improving it (that will be blocked on ESLint's making an API, I assume).
This also isn't tested yet so I'll file a followup issue for that too.