Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to relay pagination, improve the infinite scroller #1462

Merged
merged 2 commits into from
Oct 6, 2020
Merged

switch to relay pagination, improve the infinite scroller #1462

merged 2 commits into from
Oct 6, 2020

Conversation

kdembler
Copy link
Collaborator

Resolves #1268 and #1271

This PR moves Atlas to use Relay-style pagination and adds some improvements to the infinite scroller.

Notable changes:

  • updated schema to match exactly how the one generated by the query node would look like
  • cleaned up the MirageJS server code
  • moved the query inside the infinite scroller component
  • made infinite scroller component properly react to category change and handle end of data

@kdembler kdembler added the atlas label Sep 25, 2020
@kdembler kdembler requested a review from fulminmaxi September 25, 2020 12:11
@kdembler kdembler mentioned this pull request Sep 28, 2020
Merged
fulminmaxi
fulminmaxi approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@fulminmaxi fulminmaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InfiniteVideoGrid API improved a lot. Good Job!

@bedeho bedeho merged commit 71cf269 into Joystream:init_atlas Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedeho bedeho bedeho approved these changes

@fulminmaxi fulminmaxi fulminmaxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdembler @bedeho @fulminmaxi