-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Overwatch League skins to each hero #264
base: development
Are you sure you want to change the base?
Conversation
Fixes issue with OWL sprays being not counted due to matching any OWL item
Merge recent changes from main repo
Python script that loops through heroes and adds all the teams' OWL skins to their data set in master.json -teamsList array will need updated when new teams are added in Season 2
This reverts commit f864571.
I just realized that this makes some superfluous changes. Not sure how that happened, but probably due to my github incompetence. I merged the current Master branch to my fork, then did the PR off of that. These don't need changes from me: |
Nice work putting this together, I'll likely pull this locally and use some of the work you've done and make some changes. I gotta be careful with OWL stuff because because there are 12 teams + the OWL Team, then there is away team versions of every skin, soon there will also be contenders skins + away. Not to mention there will also be 6 new OWL teams next year. I mostly wanna think about how I want the data to be structured, adding 28 (34 next year) skins to every hero is just a massive bloat to the json when they're essentially all the same. |
My suggestion would be to put all the OWL league skins in their own page (like the event ones), divided either by teams or by heroes. When one of those skins is marked as owned, the hero's page would update, showing it in the list and updating the value. If it can't be shown in the list, then just update the value. |
Merging Halloween changes
Add Bastion Brick challenge and OWL season 1 Winston and Zen skins
Remove Winston and Zen skins from the OWL section since they're in the main section now
Adds OWL skins to each hero's page. Calculates totals correctly and has the skins list collapsed by default (because it's a long list and looks bad to be always on the page).
I've also included a python script I wrote that adds the necessary data directly into master.json - It would definitely be better to just handle the generation of owlskins info when doing the initial parsing of game data, but I didn't have a rawData.txt to work with and didn't know where to get one, so I wrote the python script as a brute force way of adding the data to master.json
I have a fork of this that is live here for viewing/testing: https://thetural.github.io/