Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Overwatch League skins to each hero #264

Open
wants to merge 82 commits into
base: development
Choose a base branch
from

Conversation

TheTural
Copy link

Adds OWL skins to each hero's page. Calculates totals correctly and has the skins list collapsed by default (because it's a long list and looks bad to be always on the page).

I've also included a python script I wrote that adds the necessary data directly into master.json - It would definitely be better to just handle the generation of owlskins info when doing the initial parsing of game data, but I didn't have a rawData.txt to work with and didn't know where to get one, so I wrote the python script as a brute force way of adding the data to master.json

I have a fork of this that is live here for viewing/testing: https://thetural.github.io/

@TheTural
Copy link
Author

I just realized that this makes some superfluous changes. Not sure how that happened, but probably due to my github incompetence. I merged the current Master branch to my fork, then did the PR off of that.

These don't need changes from me:
css/_global.scss
css/main.min.css
data/events.json
helpers/dataMapper/EVENTDATA.js

@Js41637
Copy link
Owner

Js41637 commented Aug 10, 2018

Nice work putting this together, I'll likely pull this locally and use some of the work you've done and make some changes.

I gotta be careful with OWL stuff because because there are 12 teams + the OWL Team, then there is away team versions of every skin, soon there will also be contenders skins + away. Not to mention there will also be 6 new OWL teams next year.

I mostly wanna think about how I want the data to be structured, adding 28 (34 next year) skins to every hero is just a massive bloat to the json when they're essentially all the same.

@Gonzom
Copy link
Contributor

Gonzom commented Aug 11, 2018

My suggestion would be to put all the OWL league skins in their own page (like the event ones), divided either by teams or by heroes. When one of those skins is marked as owned, the hero's page would update, showing it in the list and updating the value. If it can't be shown in the list, then just update the value.

TheTural added 30 commits March 9, 2019 21:29
Add OWL skins to data, also remove the All Stars skins from the OWL category/script because they're included in js41637's master.json now
Add Bastion Brick challenge and OWL season 1 Winston and Zen skins
Remove Winston and Zen skins from the OWL section since they're in the main section now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants