Skip to content

Commit

Permalink
feat(ref: #1425): start strict eslint
Browse files Browse the repository at this point in the history
  • Loading branch information
andriikamaldinov1 committed Oct 22, 2024
1 parent 5acb93b commit 28eef81
Show file tree
Hide file tree
Showing 30 changed files with 245 additions and 161 deletions.
26 changes: 13 additions & 13 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@

Please check if your PR fulfills the following requirements:

- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-mask/blob/develop/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] The commit message follows our guidelines: https://github.com/JsDaddy/ngx-mask/blob/develop/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

Expand All @@ -31,8 +31,8 @@ Issue Number: N/A

## Does this PR introduce a breaking change?

- [ ] Yes
- [ ] No
- [ ] Yes
- [ ] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

Expand Down
2 changes: 1 addition & 1 deletion .lintstagedrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"*.{ts,js,json}": [
"eslint --report-unused-disable-directives --max-warnings 0 --fix",
"prettier --write"
"prettier . --write"
],
"*.scss": "stylelint --fix"
}
12 changes: 6 additions & 6 deletions .markdownlint.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"default": true,
"MD013": false,
"MD033": false,
"MD041": false,
"MD014": false,
"MD024": false
"default": true,
"MD013": false,
"MD033": false,
"MD041": false,
"MD014": false,
"MD024": false
}
2 changes: 1 addition & 1 deletion .puppeteerrc.cjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const {join} = require('path');
const { join } = require('path');

/**
* @type {import("puppeteer").Configuration}
Expand Down
8 changes: 4 additions & 4 deletions .releaserc.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
branches:
- develop
- develop

plugins:
- '@semantic-release/commit-analyzer'
- '@semantic-release/github'
- 'semantic-release-export-data'
- '@semantic-release/commit-analyzer'
- '@semantic-release/github'
- 'semantic-release-export-data'
18 changes: 9 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
sudo: false
language: node_js
node_js:
- '18'
- '18'

cache:
directories:
- node_modules
directories:
- node_modules

addons:
chrome: stable
chrome: stable

notifications:
email: false
email: false

git:
depth: 3
depth: 3

before_install:
- npm install -g npm@^8.19.2
- npm install -g npm@^8.19.2

script:
- export CHROME_BIN=chromium-browser
- npm run ci
- export CHROME_BIN=chromium-browser
- npm run ci
65 changes: 26 additions & 39 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,12 @@
- Fix ([#1378](https://github.com/JsDaddy/ngx-mask/issues/1378))
- Fix ([#1390](https://github.com/JsDaddy/ngx-mask/issues/1390))


# 17.1.1(2024-07-05)

### Fix

- Fix ([#1383](https://github.com/JsDaddy/ngx-mask/issues/1383))


# 17.1.0(2024-07-05)

### Fix
Expand All @@ -62,8 +60,6 @@
- Fix ([#1344](https://github.com/JsDaddy/ngx-mask/issues/1344))
- Fix ([#1365](https://github.com/JsDaddy/ngx-mask/issues/1365))



# 17.0.9(2024-07-02)

### Fix
Expand All @@ -74,8 +70,6 @@
- Fix ([#1378](https://github.com/JsDaddy/ngx-mask/issues/1378))
- Fix ([#1377](https://github.com/JsDaddy/ngx-mask/issues/1377))



# 17.0.8(2024-04-30)

### Fix
Expand All @@ -87,8 +81,8 @@
### Fix

- Fix ([#1298](https://github.com/JsDaddy/ngx-mask/issues/1298))
- Fix ([#1307](https://github.com/JsDaddy/ngx-mask/issues/1307))
- Fix ([#1306](https://github.com/JsDaddy/ngx-mask/issues/1306))
- Fix ([#1307](https://github.com/JsDaddy/ngx-mask/issues/1307))
- Fix ([#1306](https://github.com/JsDaddy/ngx-mask/issues/1306))

# 17.0.6(2024-03-27)

Expand All @@ -110,27 +104,26 @@
- Fix ([#1308](https://github.com/JsDaddy/ngx-mask/issues/1308))
- Fix ([#1299](https://github.com/JsDaddy/ngx-mask/issues/1299))


# 17.0.4(2023-12-01)

### Feat

- update v16.4.2
- update v15.2.3
- update v14.3.3
- update v13.2.2
- update v16.4.2
- update v15.2.3
- update v14.3.3
- update v13.2.2

# 17.0.3(2023-11-30)

### Feat

- update dependencies
- update dependencies

# 17.0.2(2023-11-29)

### Feat

- update dependencies
- update dependencies

# 17.0.2(2023-11-29)

Expand Down Expand Up @@ -158,10 +151,11 @@
### Feature

- update ng 17.x
-
-

### Feature 16.4.2

- Upgrade version 16.4.2 with more fixes since version 17.x.x
- Upgrade version 16.4.2 with more fixes since version 17.x.x

# 16.4.1(2023-11-08)

Expand Down Expand Up @@ -194,7 +188,6 @@
- Change README.md
- Fix ([#1242](https://github.com/JsDaddy/ngx-mask/issues/1242))


# 16.3.7(2023-09-18)

### Fix
Expand All @@ -207,7 +200,6 @@

- Fix ([#1232](https://github.com/JsDaddy/ngx-mask/issues/1232))


# 16.3.5(2023-09-14)

### Fix
Expand All @@ -232,8 +224,6 @@

- Fix ([#658](https://github.com/JsDaddy/ngx-mask/issues/658))



# 16.3.1(2023-09-01)

### Fix
Expand All @@ -255,7 +245,6 @@
- Fix ([#1206](https://github.com/JsDaddy/ngx-mask/issues/1206))
- Fix ([#1211](https://github.com/JsDaddy/ngx-mask/issues/1211))


# 16.2.9(2023-08-08)

### Fix
Expand All @@ -264,7 +253,7 @@
- Fix ([#890](https://github.com/JsDaddy/ngx-mask/issues/890))
- Fix ([#841](https://github.com/JsDaddy/ngx-mask/issues/841))
- Fix ([#1162](https://github.com/JsDaddy/ngx-mask/issues/1162))

# 16.2.7(2023-08-08)

### Fix
Expand Down Expand Up @@ -480,11 +469,11 @@

### Feature 15.2.3

- Upgrade version 15.2.3 with more fixes since version 17.x.x
- Upgrade version 15.2.3 with more fixes since version 17.x.x

### Feature 15.2.1

- Upgrade version 15.2.1 with more fixes since version 16.x.x
- Upgrade version 15.2.1 with more fixes since version 16.x.x

# 15.1.5(2023-05-12)

Expand Down Expand Up @@ -573,16 +562,15 @@

### Feature 14.3.3

- Upgrade version 15.2.2 with more fixes since version 17.x.x

- Upgrade version 15.2.2 with more fixes since version 17.x.x

### Feature 14.3.2

- Upgrade version 14.3.2 with more fixes since version 16.x.x
- Change MaskPipe => NgxMaskPipe
- Change MaskService => NgxMaskService
- Change MaskApplierService => NgxMaskApplierService
- Change MaskDirective => NgxMaskMaskDirective
- Upgrade version 14.3.2 with more fixes since version 16.x.x
- Change MaskPipe => NgxMaskPipe
- Change MaskService => NgxMaskService
- Change MaskApplierService => NgxMaskApplierService
- Change MaskDirective => NgxMaskMaskDirective

# 14.2.4(2022-10-27)

Expand Down Expand Up @@ -657,16 +645,15 @@

### Feature 13.3.2

- Upgrade version 13.2.2 with more fixes since version 17.x.x

- Upgrade version 13.2.2 with more fixes since version 17.x.x

### Feature 13.2.1

- Upgrade version 13.2.1 with more fixes since version 16.x.x
- Change MaskPipe => NgxMaskPipe
- Change MaskService => NgxMaskService
- Change MaskApplierService => NgxMaskApplierService
- Change MaskDirective => NgxMaskMaskDirective
- Upgrade version 13.2.1 with more fixes since version 16.x.x
- Change MaskPipe => NgxMaskPipe
- Change MaskService => NgxMaskService
- Change MaskApplierService => NgxMaskApplierService
- Change MaskDirective => NgxMaskMaskDirective

<a name="13.2.1"></a>

Expand Down
32 changes: 16 additions & 16 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@ diverse, inclusive, and healthy community.
Examples of behavior that contributes to a positive environment for our
community include:

* Demonstrating empathy and kindness toward other people
* Being respectful of differing opinions, viewpoints, and experiences
* Giving and gracefully accepting constructive feedback
* Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
* Focusing on what is best not just for us as individuals, but for the
overall community
- Demonstrating empathy and kindness toward other people
- Being respectful of differing opinions, viewpoints, and experiences
- Giving and gracefully accepting constructive feedback
- Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
- Focusing on what is best not just for us as individuals, but for the
overall community

Examples of unacceptable behavior include:

* The use of sexualized language or imagery, and sexual attention or
advances of any kind
* Trolling, insulting or derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or email
address, without their explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting
- The use of sexualized language or imagery, and sexual attention or
advances of any kind
- Trolling, insulting or derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or email
address, without their explicit permission
- Other conduct which could reasonably be considered inappropriate in a
professional setting

## Enforcement Responsibilities

Expand Down Expand Up @@ -106,7 +106,7 @@ Violating these terms may lead to a permanent ban.
### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
Expand Down
14 changes: 7 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@ Please format code and markup in your issue using [github markdown](https://help

## Contributing to Source Code (Pull Requests)

- If your PR changes any behavior or fixes an issue, it should have an associated test.
- New features should be general and as simple as possible.
- Breaking changes should be avoided if possible.
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).
- If your PR changes any behavior or fixes an issue, it should have an associated test.
- New features should be general and as simple as possible.
- Breaking changes should be avoided if possible.
- All pull requests require review. No PR will be merged without a comment from a team member stating LGTM (Looks good to me).

## Protractor specific rules

- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
- Document public methods with jsdoc.
- Be consistent with the code around you!
- JavaScript style should generally follow the [Google JS style guide](https://google.github.io/styleguide/javascriptguide.xml).
- Document public methods with jsdoc.
- Be consistent with the code around you!

## Commit Messages

Expand Down
Loading

0 comments on commit 28eef81

Please sign in to comment.