Skip to content

Commit

Permalink
feat(ref: #188): change type imports
Browse files Browse the repository at this point in the history
  • Loading branch information
andriikamaldinov1 committed Oct 30, 2024
1 parent 6b84685 commit c91177f
Show file tree
Hide file tree
Showing 48 changed files with 110 additions and 86 deletions.
11 changes: 4 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

### Enhancement

- add tailwind
- change interface to type, remove prefix "I"
- update dependencies
- add ESLint strict rules
- add tailwind
- change interface to type, remove prefix "I"
- update dependencies
- add ESLint strict rules

### Fix

Expand All @@ -18,9 +18,6 @@
- Fix ([#1344](https://github.com/JsDaddy/ngx-mask/issues/1344))
- Fix ([#1356](https://github.com/JsDaddy/ngx-mask/issues/1356))




# 17.1.8(2024-07-16)

### Fix
Expand Down
2 changes: 2 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ module.exports = tseslint.config(
'@typescript-eslint/unbound-method': 'off',
'import/no-cycle': 'off',
'import/extensions': 'off',
'@typescript-eslint/consistent-type-imports': 'error',
'@typescript-eslint/consistent-type-exports': 'error',
},
},
{
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/lib/ngx-mask-applier.service.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { inject, Injectable } from '@angular/core';
import { NGX_MASK_CONFIG, Config } from './ngx-mask.config';
import type { Config } from './ngx-mask.config';
import { NGX_MASK_CONFIG } from './ngx-mask.config';
import { MaskExpression } from './ngx-mask-expression.enum';

@Injectable()
Expand Down
22 changes: 7 additions & 15 deletions projects/ngx-mask-lib/src/lib/ngx-mask.directive.ts
Original file line number Diff line number Diff line change
@@ -1,25 +1,17 @@
import { DOCUMENT } from '@angular/common';
import {
Directive,
EventEmitter,
HostListener,
Input,
OnChanges,
Output,
SimpleChanges,
inject,
} from '@angular/core';
import {
import type { OnChanges, SimpleChanges } from '@angular/core';
import { Directive, EventEmitter, HostListener, Input, Output, inject } from '@angular/core';
import type {
ControlValueAccessor,
FormControl,
NG_VALIDATORS,
NG_VALUE_ACCESSOR,
ValidationErrors,
Validator,
} from '@angular/forms';
import { NG_VALIDATORS, NG_VALUE_ACCESSOR } from '@angular/forms';

import { CustomKeyboardEvent } from './custom-keyboard-event';
import { Config, NGX_MASK_CONFIG, timeMasks, withoutValidation } from './ngx-mask.config';
import type { CustomKeyboardEvent } from './custom-keyboard-event';
import type { Config } from './ngx-mask.config';
import { NGX_MASK_CONFIG, timeMasks, withoutValidation } from './ngx-mask.config';
import { NgxMaskService } from './ngx-mask.service';
import { MaskExpression } from './ngx-mask-expression.enum';

Expand Down
6 changes: 4 additions & 2 deletions projects/ngx-mask-lib/src/lib/ngx-mask.pipe.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { inject, Pipe, PipeTransform } from '@angular/core';
import type { PipeTransform } from '@angular/core';
import { inject, Pipe } from '@angular/core';

import { Config, NGX_MASK_CONFIG } from './ngx-mask.config';
import type { Config } from './ngx-mask.config';
import { NGX_MASK_CONFIG } from './ngx-mask.config';
import { NgxMaskService } from './ngx-mask.service';
import { MaskExpression } from './ngx-mask-expression.enum';

Expand Down
12 changes: 4 additions & 8 deletions projects/ngx-mask-lib/src/lib/ngx-mask.providers.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import { EnvironmentProviders, inject, makeEnvironmentProviders, Provider } from '@angular/core';
import type { EnvironmentProviders, Provider } from '@angular/core';
import { inject, makeEnvironmentProviders } from '@angular/core';

import {
NGX_MASK_CONFIG,
INITIAL_CONFIG,
initialConfig,
NEW_CONFIG,
optionsConfig,
} from './ngx-mask.config';
import type { optionsConfig } from './ngx-mask.config';
import { NGX_MASK_CONFIG, INITIAL_CONFIG, initialConfig, NEW_CONFIG } from './ngx-mask.config';
import { NgxMaskService } from './ngx-mask.service';

/**
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/lib/ngx-mask.service.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { ElementRef, inject, Injectable, Renderer2 } from '@angular/core';
import { DOCUMENT } from '@angular/common';

import { NGX_MASK_CONFIG, Config } from './ngx-mask.config';
import type { Config } from './ngx-mask.config';
import { NGX_MASK_CONFIG } from './ngx-mask.config';
import { NgxMaskApplierService } from './ngx-mask-applier.service';
import { MaskExpression } from './ngx-mask-expression.enum';

Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/add-prefix.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { equal } from './utils/test-functions.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/add-suffix.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/basic-logic.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { DebugElement } from '@angular/core';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import type { DebugElement } from '@angular/core';
import { By } from '@angular/platform-browser';
import { ReactiveFormsModule } from '@angular/forms';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { equal } from './utils/test-functions.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/complete-mask.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Component } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { FormControl, ReactiveFormsModule } from '@angular/forms';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/copy-paste.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/custom-date.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { equal } from './utils/test-functions.component';
Expand Down
6 changes: 4 additions & 2 deletions projects/ngx-mask-lib/src/test/custom-patterns.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
import { equal } from './utils/test-functions.component';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { Config, initialConfig } from 'ngx-mask';
import type { Config } from 'ngx-mask';
import { initialConfig } from 'ngx-mask';

describe('Directive: Mask (Custom patterns)', () => {
let fixture: ComponentFixture<TestMaskComponent>;
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/custom-symbol-regexp.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/default-config.spec.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule, FormControl } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { provideEnvironmentNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { optionsConfig } from '../lib/ngx-mask.config';
import type { optionsConfig } from '../lib/ngx-mask.config';

function createComponentWithDefaultConfig(
defaultConfig?: optionsConfig
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/delete.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/dynamic.spec.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';

import { By } from '@angular/platform-browser';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { equal } from './utils/test-functions.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/export-as.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { Component, ViewChild } from '@angular/core';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/inputTransformFn.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/mask.pipe.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { TestBed } from '@angular/core/testing';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskPipe } from '../lib/ngx-mask.pipe';
import { Config, NgxMaskDirective } from 'ngx-mask';
import type { Config } from 'ngx-mask';
import { NgxMaskDirective } from 'ngx-mask';

describe('Pipe: Mask', () => {
let maskPipe: NgxMaskPipe;
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/percent.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/repeat-mask.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/secure-mask.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { fakeAsync, TestBed, tick } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
import { equal, typeTest } from './utils/test-functions.component';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { By } from '@angular/platform-browser';

describe('Directive: Mask (Secure)', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import { DebugElement, LOCALE_ID } from '@angular/core';
import type { ComponentFixture } from '@angular/core/testing';
import { fakeAsync, TestBed, tick } from '@angular/core/testing';
import type { DebugElement } from '@angular/core';
import { LOCALE_ID } from '@angular/core';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { equal, typeTest } from './utils/test-functions.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/separator.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { fakeAsync, TestBed, tick } from '@angular/core/testing';
import { By } from '@angular/platform-browser';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { equal, typeTest } from './utils/test-functions.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/show-mask-typed.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
import { equal } from './utils/test-functions.component';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { By } from '@angular/platform-browser';

describe('Directive: Mask', () => {
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/test-sufix.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { DebugElement } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { DebugElement } from '@angular/core';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';
import { By } from '@angular/platform-browser';
import { TestMaskComponent } from './utils/test-component.component';
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/time-mask.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { ReactiveFormsModule } from '@angular/forms';

import { TestMaskComponent } from './utils/test-component.component';
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx-mask-lib/src/test/trigger-on-mask-change.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';

import { By } from '@angular/platform-browser';
import { ReactiveFormsModule } from '@angular/forms';
import { TestMaskComponent } from './utils/test-component.component';
import { provideNgxMask } from '../lib/ngx-mask.providers';
import { NgxMaskDirective } from '../lib/ngx-mask.directive';
import { DebugElement } from '@angular/core';
import type { DebugElement } from '@angular/core';
import { equal } from './utils/test-functions.component';

describe('Directive: Mask (Trigger on mask change)', () => {
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx-mask-lib/src/test/type-number.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Component } from '@angular/core';
import { FormControl, ReactiveFormsModule } from '@angular/forms';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { ComponentFixture } from '@angular/core/testing';
import { TestBed } from '@angular/core/testing';
import { NgxMaskDirective, provideNgxMask } from 'ngx-mask';
import { equal } from './utils/test-functions.component';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { Component, inject, Input } from '@angular/core';
import { FormControl } from '@angular/forms';
import { scan, startWith } from 'rxjs';
import { Config, NGX_MASK_CONFIG } from 'ngx-mask';
import type { Config } from 'ngx-mask';
import { NGX_MASK_CONFIG } from 'ngx-mask';

@Component({
selector: 'jsdaddy-open-source-test',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Component, OnDestroy, OnInit } from '@angular/core';
import type { OnDestroy, OnInit } from '@angular/core';
import { Component } from '@angular/core';
import { FormControl } from '@angular/forms';
import { Subject, takeUntil } from 'rxjs';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ChangeDetectorRef, Component, inject } from '@angular/core';
import { FormControl } from '@angular/forms';

import { Config } from '../../lib/ngx-mask.config';
import type { Config } from '../../lib/ngx-mask.config';

@Component({
selector: 'jsdaddy-open-source-test',
Expand Down
Loading

0 comments on commit c91177f

Please sign in to comment.