Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deletion of text does not work properly in Chrome with ViewEncapsulation.ShadowDom #909

Closed
andrewritchie opened this issue Jun 8, 2021 · 1 comment
Closed

Deletion of text does not work properly in Chrome with ViewEncapsulation.ShadowDom #909

andrewritchie opened this issue Jun 8, 2021 · 1 comment

Comments

@andrewritchie
Copy link

🐞 bug report

Is this a regression?

No; I tested this with both 10.x and 12.0.0 and this does not work with either.

Description

Specifying an input mask with [showMaskTyped]="true", or an input mask with special characters that involve spaces, such as the phone number mask "(000) 000-0000", does not work allow proper deletion of characters in desktop browsers if the component's encapsulation is set to ViewEncapsulation.ShadowDom.

With showMaskTyped=true, only the last character is deleted when backspace is pressed if the encapsulation is ViewEncapsulation.ShadowDom.
With showMaskTyped=false, the space after the ) in the mask prevents further backspacing if the encapsulation is ViewEncapsulation.ShadowDom

🔬 Minimal Reproduction

https://stackblitz.com/edit/angular-ivy-v4yznq

🔥 Exception or Error

None

🌍 Your Environment

Angular Version:




11.2.14

Anything else relevant?

I tested this with Google Chrome 91.0.4472.77.

I have attempted reproducing this on Chrome on my Android phone, and was unable to do so.
andrewritchie pushed a commit to andrewritchie/ngx-mask that referenced this issue Jun 8, 2021
fix(JsDaddy#909): Fixed issue where active elements within a shadowRo…
e74639b 
…ot would not be found by mask.
@andrewritchie andrewritchie mentioned this issue Jun 8, 2021
Closed
13 tasks
xakeppok pushed a commit that referenced this issue Apr 14, 2022
fix(#909): issue where active elements within a shadowRoot would not …
d72b8ed 
…be found by mask
xakeppok pushed a commit that referenced this issue Apr 14, 2022
fix(#909): update changelog
2d31b7e
xakeppok pushed a commit that referenced this issue Apr 14, 2022
fix(#909): resolve merge conflicts
f006893
@xakeppok xakeppok reopened this Apr 26, 2022
xakeppok pushed a commit that referenced this issue Apr 26, 2022
fix(#909): added tests
8d1ba93
xakeppok pushed a commit that referenced this issue Apr 26, 2022
fix(#909): resolve merge conflicts
4aaab89
xakeppok pushed a commit that referenced this issue Apr 27, 2022
fix(#909): resolve merge conflicts
03fe7a4
NepipenkoIgor pushed a commit that referenced this issue Apr 27, 2022
@xakeppok
Fix/909 (#997)
1606ff1 
* fix(#909): issue where active elements within a shadowRoot would not be found by mask

* fix(#909): update changelog

* fix(#909): added tests

Co-authored-by: Vladislav <[email protected]>
@NepipenkoIgor
Copy link
Collaborator

@andrewritchie Hi thank you that using ngx-mask . Please use ngx-mask >=13.1.12

@sspears-deloitte sspears-deloitte mentioned this issue Aug 15, 2023
Closed
@stevenspears stevenspears mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NepipenkoIgor @andrewritchie @xakeppok