Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1079): patch fix #1069 into 14.2 version for compatibility #1080

Conversation

mikaelboff
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Issue related: #1079

I'm creating this pull request to patch the Fix (#1069) into version 14.2 and create version 14.2.5.

The reason to this is to maintain compatibility for projects with angular version < 14, since This commit has changed the peer dependencies of angular version to >=14.0.0.

@mikaelboff
Copy link
Contributor Author

Hi, can you review this, please? @NepipenkoIgor

@mikaelboff
Copy link
Contributor Author

Hi @NepipenkoIgor , could you please check this?

@mikaelboff
Copy link
Contributor Author

@andriikamaldinov1 @NepipenkoIgor could you guys please consider this?

@NepipenkoIgor
Copy link
Collaborator

@mikaelboff Thank you for this patch . But as i remember we added fixes for later versions. We don't have strategy in this moment to have LTS or something like this. Its mean that we care about latest releases and adopting ngx-mask to latest versions of angular. In general for ng14 we could use ngx-mask > 15.0.0 that include your fix . The main difference that for delivery ngx-mask we will not using ngModule any more

@NepipenkoIgor
Copy link
Collaborator

@mikaelboff if you agree please close PR and issues relative to it . And we will waiting you contributing in future

@mikaelboff
Copy link
Contributor Author

@mikaelboff Thank you for this patch . But as i remember we added fixes for later versions. We don't have strategy in this moment to have LTS or something like this. Its mean that we care about latest releases and adopting ngx-mask to latest versions of angular. In general for ng14 we could use ngx-mask > 15.0.0 that include your fix . The main difference that for delivery ngx-mask we will not using ngModule any more

The main reason I'm requesting this patch is to an application with Angular version < 14. Updating the application source to adapt to new versions would cost me a lot; but if there's no chance of patching the fix with these merge request, I'll have to close it, fork the lib and apply the patch myself, until there's time to upgrade the source code of my application to use > 14 angular version. There isn't really any little chance of patching/publishing on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants