Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#601) #1168

Merged
merged 10 commits into from
Jun 8, 2023
Merged

Fix(#601) #1168

merged 10 commits into from
Jun 8, 2023

Conversation

andriikamaldinov1
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@@ -454,6 +458,12 @@ export class NgxMaskService extends NgxMaskApplierService {
if (!this.isNumberValue || value === '') {
return value;
}
if (
this.maskExpression.startsWith('separator') &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create enum for this kind of strings ?

@NepipenkoIgor NepipenkoIgor merged commit 368b1c0 into develop Jun 8, 2023
@NepipenkoIgor NepipenkoIgor deleted the fix(#601) branch June 8, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants