Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving code base #37

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Improving code base #37

merged 4 commits into from
Mar 4, 2024

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Jan 8, 2024

  • Separating functions in individual files
  • Eyecandy changes (file renaming)
  • Fixing Documenter failing on pipeline

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.07%. Comparing base (de98ac2) to head (60a2535).

Files Patch % Lines
src/experiments.jl 83.33% 4 Missing ⚠️
src/types/mlflow.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   77.71%   78.07%   +0.36%     
==========================================
  Files           9       10       +1     
  Lines         332      333       +1     
==========================================
+ Hits          258      260       +2     
+ Misses         74       73       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deyandyankov
Copy link
Collaborator

looks good to me @pebeto - have you got access to juliahub and permissions to trigger new releases?

@ablaom
Copy link
Member

ablaom commented Jan 16, 2024

@pebeto Maybe you can make codecov less fussy with an addition like this one

@pebeto pebeto merged commit 776695b into JuliaAI:main Mar 4, 2024
5 checks passed
@pebeto pebeto deleted the improving_code_base branch March 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants