List datasets #10
List datasets #10
Conversation
|
@jbrea Thanks for looking into this. Please see my comments re DataFrames as dependency in your other PR #9 which I looked at first. Does this PR branch off the other?
Is this to browse the available data sets at OpenML, or to inspect a particular data set? Could you explain a bit more. Maybe give an example? |
|
Thanks for your feedback, @ablaom! Things should be fixed now. Dependency on DataFrames is dropped and the PR doesn't branch off the other one anymore. |
| ``` | ||
| """ | ||
| describe_dataset(id) = Text(load_Dataset_Description(id)["data_set_description"]["description"]) | ||
|
|
There was a problem hiding this comment.
Instead of wrapping the string (?) in Text(...), how about applying Markdown.parse(...) to get proper markdown display? You will need to add using Markdown.
There was a problem hiding this comment.
Good point, thanks. I changed this in the latest commit.
|
Now that you reference it in the "public" docstring for MLJOpenML.list_datasets("/tag/OpenML100/number of instances/<1000")before realising "number of instances" should have no spaces. If I remove the spaces, I get a different error, a bug perhaps? julia> MLJOpenML.list_datasets("/tag/OpenML100/numberinstances/<1000")
Error occurred : HTTP.ExceptionRequest.StatusError(400, "GET", "/api/v1/json/data/list//tag/OpenML100/numberinstances/<1000", HTTP.Messages.Response:
"""
HTTP/1.1 400 Bad Request
Date: Tue, 13 Jul 2021 23:38:38 GMT
Server: Apache/2.4.29 (Ubuntu)
Content-Length: 1134
Connection: close
Content-Type: text/html; charset=UTF-8
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
<style type="text/css">
::selection { background-color: #E13300; color: white; }
::-moz-selection { background-color: #E13300; color: white; }
body {
background-color: #fff;
margin: 40px;
font: 13px/20px normal Helvetica, Arial, sans-serif;
color: #4F5155;
}
a {
color: #003399;
background-color: transparent;
font-weight: normal;
}
h1 {
color: #444;
background-color: transparent;
border-bottom: 1px solid #D0D0D0;
font-size: 19px;
font-weight: normal;
margin: 0 0 14px 0;
padding: 14px 15px 10px 15px;
}
code {
font-family: Consolas, Monaco, Courier New, Courier, monospace;
font-size: 12px;
background-color: #f9f9f9;
border: 1px solid #D0D0D0;
color: #002166;
display: block;
margin: 14px 0 14px 0;
padding: 12px 10px 12px 10px;
}
#container {
margin: 10px;
border: 1px solid #D0D0D0;
box-shadow: 0 0 8px #D0D0D0;
}
p {
margin: 12px 15px 12px 15px;
}
</style>
</head>
<body>
<di
⋮
1134-byte body
""")
ERROR: MethodError: no method matching getindex(::Nothing, ::String)
Stacktrace:
[1] list_datasets(filter::String; api_key::String, output_format::Type{NamedTuple})
@ MLJOpenML ~/Dropbox/Julia7/MLJ/MLJOpenML/src/openml.jl:280
[2] list_datasets(filter::String)
@ MLJOpenML ~/Dropbox/Julia7/MLJ/MLJOpenML/src/openml.jl:279
[3] top-level scope
@ REPL[71]:1Also, what is the meaning of "data/list" in "'/data/list/{filter}/{value}/{filter}/{value}/..." . @jbrea Would you be willing to give this doc-string some attention? |
|
I think that docstring is taken pretty much as is from the API description, which, in turn, I find rather cryptic. |
Codecov Report
@@ Coverage Diff @@
## dev #10 +/- ##
===========================================
- Coverage 54.46% 42.65% -11.81%
===========================================
Files 1 1
Lines 112 143 +31
===========================================
Hits 61 61
- Misses 51 82 +31
Continue to review full report at Codecov.
|
Ahh. In that case, rather than duplicating poor documentation, let's provide a link to the poor documentation. Ie, have the Maybe add a more detailed example that you know works. |
|
OK, this should be ready to be merged. |
This is just a helper to browse the datasets easily.