Merge pull request #229 from N5N3/1stindex

fix for `firstindex(128:static(-1):1)`
JuliaArrays · Dec 22, 2021 · ec8d2c7 · ec8d2c7
2 parents fedb318 + 9126b0f
commit ec8d2c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/ranges.jl b/src/ranges.jl
@@ -214,7 +214,6 @@ known_step(::Type{<:OptionallyStaticStepRange{<:Any,StaticInt{S}}}) where {S} =
 known_last(::Type{<:OptionallyStaticUnitRange{<:Any,StaticInt{L}}}) where {L} = L::Int
 known_last(::Type{<:OptionallyStaticStepRange{<:Any,<:Any,StaticInt{L}}}) where {L} = L::Int
 
-Base.firstindex(x::OptionallyStaticRange) = first(x)
 @inline function Base.first(r::OptionallyStaticRange)::Int
     if known_first(r) === nothing
         return getfield(r, :start)

diff --git a/test/ranges.jl b/test/ranges.jl
@@ -113,5 +113,7 @@
 
     @test @inferred(eachindex(static(-7):static(7))) === static(1):static(15)
     @test @inferred((static(-7):static(7))[first(eachindex(static(-7):static(7)))]) == -7
+
+    @test @inferred(firstindex(128:static(-1):1)) == 1
 end