Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve offsets on broadcasting IdOffsetRange #114

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

yha
Copy link
Contributor

@yha yha commented Jun 10, 2020

An updated version of #105.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #114 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   83.69%   83.68%   -0.02%     
==========================================
  Files           2        2              
  Lines         184      190       +6     
==========================================
+ Hits          154      159       +5     
- Misses         30       31       +1     
Impacted Files Coverage Δ
src/axes.jl 75.60% <100.00%> (+3.38%) ⬆️
src/OffsetArrays.jl 85.90% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7294f3d...45c7e8e. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnychen94
Copy link
Member

I'm merging this with a minor version bump

@johnnychen94 johnnychen94 merged commit ed04fda into JuliaArrays:master Jun 17, 2020
johnnychen94 added a commit to yha/ImageFiltering.jl that referenced this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants