Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OffsetMatrix type alias #131

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

sostock
Copy link
Contributor

@sostock sostock commented Aug 12, 2020

Analogous to OffsetVector, this PR adds OffsetMatrix.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #131 into master will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   84.53%   84.26%   -0.28%     
==========================================
  Files           2        2              
  Lines         194      197       +3     
==========================================
+ Hits          164      166       +2     
- Misses         30       31       +1     
Impacted Files Coverage Δ
src/OffsetArrays.jl 86.53% <100.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e907809...8f388a0. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timholy timholy merged commit c6fae67 into JuliaArrays:master Aug 13, 2020
@timholy
Copy link
Member

timholy commented Aug 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants