Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reshape on non-vector arrays #151

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix reshape on non-vector arrays #151

merged 1 commit into from
Sep 18, 2020

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Sep 18, 2020

A bug introduced by #88 😮

julia> using OffsetArrays

julia> A = rand(4, 4);

julia> reshape(A, :) |> axes
(Base.OneTo(16),)

julia> reshape(OffsetArray(A, 0, 0), :) |>  axes
(1:4, 1:4)

No new ambiguity here.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #151 into master will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   93.60%   94.02%   +0.42%     
==========================================
  Files           2        2              
  Lines         250      251       +1     
==========================================
+ Hits          234      236       +2     
+ Misses         16       15       -1     
Impacted Files Coverage Δ
src/OffsetArrays.jl 94.68% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e60d3...753ede8. Read the comment docs.

@johnnychen94 johnnychen94 merged commit 535efad into master Sep 18, 2020
@johnnychen94 johnnychen94 deleted the jc/reshape branch September 18, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant