Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on nightly #272

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fix tests on nightly #272

merged 1 commit into from
Apr 12, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Apr 11, 2022

JuliaLang/julia#44939 was leading to test failures, but this should be a Vector{Any} anyway

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #272 (2cae7c8) into master (54ade62) will decrease coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   96.52%   95.86%   -0.66%     
==========================================
  Files           5        5              
  Lines         460      460              
==========================================
- Hits          444      441       -3     
- Misses         16       19       +3     
Impacted Files Coverage Δ
src/utils.jl 96.00% <0.00%> (-2.00%) ⬇️
src/OffsetArrays.jl 97.76% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ade62...2cae7c8. Read the comment docs.

Copy link
Collaborator

@chriselrod chriselrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, vectors automatically promote more aggressively now.

@jishnub jishnub merged commit d97c1be into JuliaArrays:master Apr 12, 2022
@jishnub jishnub deleted the testfix branch April 12, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants