Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid runtime static parameters inference during dynamic dispatch of SVector{k} #1157

Merged
merged 4 commits into from
Apr 28, 2023

Conversation

BioTurboNick
Copy link
Contributor

Fixes #1148 by implementing @N5N3 's suggestion.

@N5N3
Copy link
Contributor

N5N3 commented Apr 28, 2023

Perhaps the title should be “Avoid runtime static parameters inference during dynamic dispatch of SVector{k}”.

@BioTurboNick BioTurboNick changed the title Avoid dynamic dispatch with SVector{k} Avoid runtime static parameters inference during dynamic dispatch of SVector{k} Apr 28, 2023
@BioTurboNick
Copy link
Contributor Author

I'm gathering the nightly failures are unrelated to this PR, since they also show up in a more recent PR.

Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Could you just bump patch version?

Project.toml Outdated Show resolved Hide resolved
@mateuszbaran mateuszbaran merged commit b4e49ce into JuliaArrays:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potentially address performance regression with Julia 1.9
3 participants