Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specialize cconvert instead of unsafe_convert #1236

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Specialize cconvert instead of unsafe_convert #1236

merged 2 commits into from
Jan 25, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 24, 2024 •
edited
Loading

These changes should address some of the breakages related to pointer on julia nightly that are reported in JuliaLang/julia#51962

mateuszbaran
mateuszbaran approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine. Could you just add a test for cconvert?

@jishnub
Copy link
Member Author

jishnub commented Jan 25, 2024

I've added a test which mimics the definition. On julia nightly, the tests for pointer would test cconvert as well, so additional tests exist implicitly.

@jishnub jishnub merged commit 819dbc6 into JuliaArrays:master Jan 25, 2024
24 of 29 checks passed
@jishnub jishnub deleted the unsafe_convertPtr branch January 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszbaran mateuszbaran mateuszbaran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @mateuszbaran