Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give informative message for parsing errors #43

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Nov 23, 2020

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #43 (0d8c65f) into master (47f880e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   96.41%   96.46%   +0.04%     
==========================================
  Files           4        4              
  Lines         223      226       +3     
==========================================
+ Hits          215      218       +3     
  Misses          8        8              
Impacted Files Coverage Δ
src/CoverageTools.jl 98.31% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f880e...0d8c65f. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 23, 2020

Pull Request Test Coverage Report for Build 83

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.297%

Totals Coverage Status
Change from base Build 75: 0.04%
Covered Lines: 180
Relevant Lines: 185

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 79

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.297%

Totals Coverage Status
Change from base Build 75: 0.04%
Covered Lines: 180
Relevant Lines: 185

💛 - Coveralls

src/CoverageTools.jl Outdated Show resolved Hide resolved
src/CoverageTools.jl Outdated Show resolved Hide resolved
src/CoverageTools.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@fingolfin fingolfin merged commit 1e50bda into master Dec 2, 2020
@fingolfin fingolfin deleted the teh/informerr branch December 2, 2020 23:52
@timholy
Copy link
Member Author

timholy commented Dec 3, 2020

Thanks for fixing it!

@fingolfin
Copy link
Member

Thanks for making the PR :-) Very nice improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants