-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow removal of .mem files alongside .cov files #72
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
===========================================
- Coverage 100.00% 98.54% -1.46%
===========================================
Files 4 4
Lines 271 274 +3
===========================================
- Hits 271 270 -1
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. |
I don't understand this test failure. It looks more like a change in the way Julia nightly reports a particular exception:
|
bump - can anyone respond here? |
Ran into the same issue with #73 It comes from the Julia parser, giving different output with each Julia version. I have fixed it for current |
@Azzaare I doubt anything will be accepted here. The last activity on this repo was 3 years ago. |
@bluesmoon PR #73 was merged! You can probably rebase on master now and have the tests pass! |
end | ||
|
||
""" | ||
clean_folder(folder::AbstractString) | ||
clean_folder(folder::AbstractString; include_memfiles::Bool=false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe include_memfiles
is not the best name (also_memfiles
? also not great)
Well naming is hard. I think it is good enough 🤷
No description provided.