TypeError causing segfault in Julia 1.6 tests

[mjram0s]

https://github.com/invenia/PkgTemplates.jl/runs/2198570926?check_suite_focus=true#step:7:187

Internal error: encountered unexpected error in runtime:
TypeError(func=:TypeVar, context="upper bound", expected=Type, got=Vararg{Any, N} where N)
jl_type_error_rt at /buildworker/worker/package_linux64/build/src/rtutils.c:119
jl_new_typevar at /buildworker/worker/package_linux64/build/src/builtins.c:1116
TypeVar at ./boot.jl:382
apply_type_tfunc at ./compiler/tfuncs.jl:1231
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2237 [inlined]
jl_apply_generic at /buildworker/worker/package_linux64/build/src/gf.c:2419
jl_apply at /buildworker/worker/package_linux64/build/src/julia.h:1703 [inlined]
do_apply at /buildworker/worker/package_linux64/build/src/builtins.c:670
builtin_tfunction at ./compiler/tfuncs.jl:1488
abstract_call_builtin at ./compiler/abstractinterpretation.jl:826
jfptr_abstract_call_builtin_9925.clone_1 at /opt/hostedtoolcache/julia/1.6.0/x64/lib/julia/sys.so (unknown line)
...

[christopher-dG]

SimpleMock/Cassette is still kinda broken on 1.6, sadly.

[nicoleepp]

Is it worth restricting the package tests to 1.5?

[nickrobinson251]

Since v1.6 is the stable release of Julia, and v1.5 is effectively now unmaintained, we really should be testing this packages works on v1.6. (I know anything that works on v1.5 should work on v1.6, but we should be testing on v1.6 to be sure).

What are our options for getting tests working on v1.6?

Is it to either

• replace SimpleMock.jl with a mocking package that works on v1.6 (which unfortunately would probably means a new dependency that's not a test-only dependency), or
• fix SimpleMock.jl, which requires fixing Cassette.jl on v1.6 (which is... hard or impossible)?

...is there another option?

cc @christopher-dG

[christopher-dG]

replace SimpleMock.jl with a mocking package that works on v1.6 (which unfortunately would probably means a new dependency that's not a test-only dependency)

I'm not super familiar with Mocking.jl's capabilities but that might be an option

fix SimpleMock.jl, which requires fixing Cassette.jl on v1.6 (which is... hard or impossible)?

It's definitely beyond my abilities. I've also been toying with the idea of migrating SimpleMock from Cassette to Mixtape, but there are still many unknowns there.

Another option is to refactor the tests to not require any mocking, or to just disable those tests.

[iamed2]

I'm not super familiar with Mocking.jl's capabilities but that might be an option

Mocking.jl requires annotating the code where you want to mock. That's the main difference from a Cassette-type approach. The usage README is pretty good.

[mjram0s]

I will work on switching this over to Mocking.jl