Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import PkgTemplates and using PkgTemplates on the latest Julia master #295

Closed
wants to merge 1 commit into from
Closed

Fix import PkgTemplates and using PkgTemplates on the latest Julia master #295

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

This fixes #294 for me locally.

@DilumAluthge
Copy link
Member Author

cc: @christopher-dG @nickrobinson251

@DilumAluthge
Copy link
Member Author

The test failures are unrelated to this PR, and seem to be caused by Cassette.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #295 (e180f3a) into master (4302ecb) will decrease coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   94.40%   93.91%   -0.50%     
==========================================
  Files          20       20              
  Lines         608      608              
==========================================
- Hits          574      571       -3     
- Misses         34       37       +3     
Impacted Files Coverage Δ
src/plugins/documenter.jl 84.05% <ø> (ø)
src/plugins/tests.jl 100.00% <ø> (ø)
src/show.jl 90.47% <0.00%> (-4.77%) ⬇️
src/plugins/git.jl 91.52% <0.00%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4302ecb...e180f3a. Read the comment docs.

@nickrobinson251 nickrobinson251 requested a review from mjram0s June 2, 2021 08:18
@nickrobinson251
Copy link
Collaborator

Doesn't this mean there was a breaking change to Pkg?

I thought breaking changes to stdlibs weren't allowed (in minor release of Julia)?

@DilumAluthge
Copy link
Member Author

Yeah.

JuliaLang/Pkg.jl#2477 (comment)

@nickrobinson251
Copy link
Collaborator

nickrobinson251 commented Jun 2, 2021

Yeah.

JuliaLang/Pkg.jl#2477 (comment)

Cool -- let's wait for the outcome of that discussion. My understanding is this should be fixed at the Pkg level, not here.

Edit: opened JuliaLang/Pkg.jl#2587

@DilumAluthge
Copy link
Member Author

Closing in favor of JuliaLang/Pkg.jl#2589

On a separate note, do you know why CI is failing?

@DilumAluthge DilumAluthge deleted the dpa/fix-on-julia-master branch June 2, 2021 22:49
@mjram0s
Copy link
Contributor

mjram0s commented Jun 3, 2021

Closing in favor of JuliaLang/Pkg.jl#2589

On a separate note, do you know why CI is failing?

Tests on 1.6 failing because #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import PkgTemplates fails with PkgTemplates#master and Julia master
3 participants