-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix import PkgTemplates
and using PkgTemplates
on the latest Julia master
#295
Conversation
The test failures are unrelated to this PR, and seem to be caused by Cassette. |
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 94.40% 93.91% -0.50%
==========================================
Files 20 20
Lines 608 608
==========================================
- Hits 574 571 -3
- Misses 34 37 +3
Continue to review full report at Codecov.
|
Doesn't this mean there was a breaking change to Pkg? I thought breaking changes to stdlibs weren't allowed (in minor release of Julia)? |
Cool -- let's wait for the outcome of that discussion. My understanding is this should be fixed at the Pkg level, not here. Edit: opened JuliaLang/Pkg.jl#2587 |
Closing in favor of JuliaLang/Pkg.jl#2589 On a separate note, do you know why CI is failing? |
Tests on 1.6 failing because #287 |
This fixes #294 for me locally.