-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Project.toml with Pkg's custom key order, and update reference tests to v1.7 #335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 94.68% 94.76% +0.07%
==========================================
Files 20 20
Lines 621 630 +9
==========================================
+ Hits 588 597 +9
Misses 33 33
Continue to review full report at Codecov.
|
Since Manifest.toml format v2 includes Julia version, reference tests need exactly equivalent VERSION.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
A couple small suggestions that i'd appreciate.
It also bumps the Julia version used for the reference test to check the bug this PR fixes.
This will close #298, which has been on the wish-list a long while, so i'm very grateful for you doing it!
To make it work, I added a mocking for uuid4.
Just to check my understanding: this mocking is needed as the output of uuid4()
is different in v1.6+ (post JuliaLang/julia#35872)?
Co-authored-by: Nick Robinson <[email protected]>
Co-authored-by: Nick Robinson <[email protected]>
Thanks for the review!
FYI I added
Oooh, this explains why. I was a bit puzzled why, but I agree that it explains it. (I initially speculated that the test may actually not be running because that 1.5 was not in the CI matrix before realizing the explicit |
hmm, it seems deeleting the 1.5 job from the GHA workflow file might not be sufficient, as it seems the repo is somehow still expecting a 1.5 job to run and pass... I wonder if this is something that needs changing in the repo settings (to which i don't have access) Perhaps @christopher-dG knows? And/or perhaps @oxinabox might be able to bump my permissions to allow me to access repo settiing to investigate? |
I've replaced the 1.5 required check in the repo settings with a 1.7 one :) |
Thanks! |
In Julia 1.7, Project.toml generated by PkgTemplates is not compatible with Pkg's sort order.
The order of the tables is different from how Pkg sorts them. If I update it with Pkg:
Then
git diff
shows meThis PR solves this issue with a custom
write_project
with the sort key taken form Pkg.It also bumps the Julia version used for the reference test to check the bug this PR fixes. To make it work, I added a mocking for
uuid4
.close #298