Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printnode for AbstractDict and AbstractArray #52

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

joshday
Copy link
Contributor

@joshday joshday commented Apr 14, 2020

Generalizing existing methods for Dict and Vector to their abstract types.

@codecov-io
Copy link

Codecov Report

Merging #52 into master will decrease coverage by 2.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   63.66%   61.19%   -2.48%     
==========================================
  Files           6        6              
  Lines         322      335      +13     
==========================================
  Hits          205      205              
- Misses        117      130      +13     
Impacted Files Coverage Δ
src/AbstractTrees.jl 36.36% <100.00%> (+3.03%) ⬆️
src/traits.jl 81.81% <0.00%> (-3.90%) ⬇️
src/indexing.jl 14.89% <0.00%> (-2.61%) ⬇️
src/iteration.jl 58.88% <0.00%> (-2.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c2121...b019666. Read the comment docs.

@timholy timholy merged commit 6e09f54 into JuliaCollections:master Apr 14, 2020
@timholy
Copy link
Member

timholy commented Apr 14, 2020

Thanks!

@joshday joshday deleted the jd/updates branch April 14, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants