Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update julia compat entry #88

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Conversation

rikhuijzer
Copy link
Contributor

At this moment, there are only a handful developers who know how to write valid Julia 0.7 code, so let's bump the compat entry to make contributing easier?

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #88 (9d7e7c9) into master (087ce85) will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   67.58%   68.29%   +0.71%     
==========================================
  Files           7        7              
  Lines         401      388      -13     
==========================================
- Hits          271      265       -6     
+ Misses        130      123       -7     
Impacted Files Coverage Δ
src/indexing.jl 18.36% <0.00%> (-1.25%) ⬇️
src/printing.jl 95.38% <0.00%> (ø)
src/iteration.jl 63.87% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087ce85...9d7e7c9. Read the comment docs.

@rikhuijzer
Copy link
Contributor Author

Oh wow. I didn't know that 0.7 was even available in GitHub Actions.

@jlumpe
Copy link
Collaborator

jlumpe commented Dec 28, 2021

Definitely, 0.7 is way too out of date at this point to bother supporting. I see that the tests are failing for the nightly Julia build but given that they're running fine on 1.7.0 that shouldn't be an issue.

@jlumpe jlumpe merged commit 1da64f3 into JuliaCollections:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants