Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix root check comparison #92

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

GiggleLiu
Copy link
Contributor

@GiggleLiu GiggleLiu commented Feb 19, 2022

I wrote a tree, and this tree has a sophisticated method to compare the equivalence (to be concrete, it is a sum-product tree, I need to expand the expression).
When I print such a tree with millions of nodes, it freezes because of invoking the comparison.

This minor fix will make the root check more reliable and it solves my problem perfectly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #92 (12d5a22) into master (84d2a28) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files           7        7           
  Lines         404      404           
=======================================
  Hits          276      276           
  Misses        128      128           
Impacted Files Coverage Δ
src/printing.jl 95.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d2a28...12d5a22. Read the comment docs.

@GiggleLiu
Copy link
Contributor Author

GiggleLiu commented Feb 22, 2022

Hi, this is a one character fix, so it should be very easy to review. But this fix is quite important to my project, so it would be great if someone with write permission can help review this PR. Thanks! @jlumpe @Keno

@GiggleLiu
Copy link
Contributor Author

Hello, is this repository still active?

@timholy
Copy link
Member

timholy commented Mar 19, 2022

My review queue is too large so I was hoping not to tackle this, but LGTM.

I'm going to run with this locally for a bit before releasing because changes like these can cause problems.

@timholy timholy merged commit 437aa8b into JuliaCollections:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants