allow loading of other k8s API implementations #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
======================================
Coverage 5.16% 5.17%
======================================
Files 769 770 +1
Lines 36645 36642 -3
======================================
+ Hits 1894 1897 +3
+ Misses 34751 34745 -6
Continue to review full report at Codecov.
|
Refactor to move all code generated from swagger spec into a separate module, named `ApiImpl`. `KuberContext` now optionally takes a module reference to load APIs from. It defaults to the one bundled in Kuber.jl - `ApiImpl`, but can be replaced with a different module when `KuberContext` is constructed. This will let Kuber.jl be used with code generated for a different Kubernetes API version, or for a spec with custom APIs (e.g. for CRDs).
tanmaykm
force-pushed
the
tan/apimodule
branch
from
a9fd9f2 to
a10b1d5
Compare
|
Thanks! I will try this out instead of my branch |
|
Will merge this and continue with some more changes to the code generation. |
nkottary
added a commit
that referenced
this pull request
Jan 5, 2022
Bump version from v0.5.2 to v0.6.0 since we have a new feature implemented in #45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to move all code generated from swagger spec into a separate module, named
ApiImpl.KuberContextnow optionally takes a module reference to load APIs from. It defaults to the one bundled in Kuber.jl -ApiImpl, but can be replaced with a different module whenKuberContextis constructed. This will let Kuber.jl be used with code generated for a different Kubernetes API version, or for a spec with custom APIs (e.g. for CRDs).Custom CRDs will need some more generalization of the code generator. Will do that in a separate PR.