Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to OpenAPI.jl from Swagger.jl #55

Merged
merged 4 commits into from
Jan 28, 2023
Merged

migrate to OpenAPI.jl from Swagger.jl #55

merged 4 commits into from
Jan 28, 2023

Conversation

tanmaykm
Copy link
Member

Use OpenAPI.jl instead of Swagger.jl to generate from specifications.
We can now use simple regex matching to detect API and model names from generated code instead of CSTParser. Simplifies the post-codegen steps to generate the helper mappings.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #55 (a7688be) into master (f910fff) will decrease coverage by 3.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   64.95%   61.43%   -3.53%     
==========================================
  Files           3        3              
  Lines         371      433      +62     
==========================================
+ Hits          241      266      +25     
- Misses        130      167      +37     
Impacted Files Coverage Δ
src/helpers.jl 79.54% <0.00%> (-8.30%) ⬇️
src/simpleapi.jl 42.45% <0.00%> (-0.41%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tanmaykm tanmaykm marked this pull request as ready for review January 27, 2023 07:22
@tanmaykm tanmaykm requested a review from nkottary January 27, 2023 07:22
@tanmaykm tanmaykm merged commit 4a702bb into master Jan 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the tan/openapi branch January 28, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants