Fix wrong use of reinterpret #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. Looking back, I'm kind of surprised I used |
|
|
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 98.63% 98.65% +0.01%
==========================================
Files 7 7
Lines 294 298 +4
==========================================
+ Hits 290 294 +4
Misses 4 4
Continue to review full report at Codecov.
|
|
Okay to tag this? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest and the most local fix I can come up with. If the
bufferfield is not meant to be publically accessed, it is better to use a wider array and reinterpret back toUInt8if it needs to be accessed as bytes.@staticfloat