WIP: Use Polynomials.jl instead of Polynomial.jl #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Wow, that was fast. I was doing the same thing right now :) Tests pass here (v0.3 in 32 and 64 bits), so let's merge it and update the code to operate over the polynomials using the right order later. |
simonster
added a commit
that referenced
this pull request
Jun 23, 2014
WIP: Use Polynomials.jl instead of Polynomial.jl
|
Sounds good. Sorry for the duplicated effort. |
|
No big deal, thanks for updating the code so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #30. This passes tests (at least for me on Julia 0.3), but ideally all of the prototype transformations should be changed so that they operate directly on the polynomial in the form it's stored instead of using
coeffs/lfill.