Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate empty! #1843

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Deprecate empty! #1843

merged 1 commit into from
Jun 12, 2019

Conversation

nalimilan
Copy link
Member

So that we can change it to be equivalent to empty!.(eachcol(df)).

Fix #1841.

@nalimilan
Deprecate empty!
e96969c 
So that we can change it to be equivalent to `empty!.(eachcol(df))`.
bkamins
bkamins approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@bkamins bkamins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly in a few days I will propose removing deletecols! :) and replace it with select!(df, Int[]) or something like this.

@nalimilan
Copy link
Member Author

Yeah, the deprecation will have to be updating before tagging a release, so that users don't have to migrate twice.

@nalimilan nalimilan merged commit 25e23b7 into master Jun 12, 2019
@nalimilan nalimilan deleted the nl/empty! branch June 12, 2019 11:09
@nalimilan nalimilan mentioned this pull request Jun 14, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkamins bkamins bkamins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty! should preserve columns
2 participants
@nalimilan @bkamins