Skip to content

Commit

Permalink
Add rename and rename! to Tables.jl API
Browse files Browse the repository at this point in the history
Following JuliaData/DataFrames.jl#1514 (comment).

The open question is if we want both `rename` and `rename!` in the common API (`rename` is probably more universally needed, `rename!` is applicable in DataFrames.jl but not in contexts where table does not allow changing column names in-place). I propose to have both but please comment (`rename!` can also live in DataFrames.jl only otherwise)

CC @piever - for syncing with JuliaDB.jl.
  • Loading branch information
bkamins authored Sep 4, 2019
1 parent 0dd6530 commit 5bf4648
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/operations.jl
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,6 @@ end
row, st = state
return SelectRow{typeof(row), names}(row), st
end

function rename end
function rename! end

0 comments on commit 5bf4648

Please sign in to comment.