Newbettersaving #150

meggart · 2022-07-07T14:14:03Z

Supersedes #132

Had to switch to a new branch when rebasing, sorry for the confusion

We want, that the buffersize is at most the length along the given dimension. Therefore we are penalizing buffers which are larger than the dimension length. This also surfaces the writefac parameter to the savecube function.

github-actions · 2022-07-07T14:17:57Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmarks:
- Target: 7 Jul 2022 - 14:17
- Baseline: 7 Jul 2022 - 14:17
Package commits:
- Target: 9866fd
- Baseline: 923e04
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["mapslices", "small"]`	0.01 (5%) ✅	0.18 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1031-azure #37~20.04.1-Ubuntu SMP Mon Jun 13 22:51:01 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       1198 s          1 s        196 s        545 s          0 s
       #2  2394 MHz        917 s          2 s        163 s        868 s          0 s
       
  Memory: 6.783607482910156 GB (3220.5546875 MB free)
  Uptime: 199.2 sec
  Load Avg:  1.51  1.0  0.42
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1031-azure #37~20.04.1-Ubuntu SMP Mon Jun 13 22:51:01 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       1577 s          1 s        203 s        582 s          0 s
       #2  2394 MHz        957 s          2 s        167 s       1247 s          0 s
       
  Memory: 6.783607482910156 GB (3378.68359375 MB free)
  Uptime: 241.56 sec
  Load Avg:  1.24  1.0  0.45
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmark: 7 Jul 2022 - 14:17
Package commit: 9866fd
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["mapslices", "small"]`	200.712 ms (5%)	6.836 ms	325.11 MiB (1%)	41579

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1031-azure #37~20.04.1-Ubuntu SMP Mon Jun 13 22:51:01 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       1198 s          1 s        196 s        545 s          0 s
       #2  2394 MHz        917 s          2 s        163 s        868 s          0 s
       
  Memory: 6.783607482910156 GB (3220.5546875 MB free)
  Uptime: 199.2 sec
  Load Avg:  1.51  1.0  0.42
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmark: 7 Jul 2022 - 14:17
Package commit: 923e04
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["mapslices", "small"]`	14.547 s (5%)	836.702 ms	1.73 GiB (1%)	27548315

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.13.0-1031-azure #37~20.04.1-Ubuntu SMP Mon Jun 13 22:51:01 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2394 MHz       1577 s          1 s        203 s        582 s          0 s
       #2  2394 MHz        957 s          2 s        167 s       1247 s          0 s
       
  Memory: 6.783607482910156 GB (3378.68359375 MB free)
  Uptime: 241.56 sec
  Load Avg:  1.24  1.0  0.45
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           63
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:                        2
CPU MHz:                         2394.454
BogoMIPS:                        4788.90
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        30 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor	:Intel
Architecture	:Haswell
Model	Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 30720) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

codecov · 2022-07-07T14:19:50Z

Codecov Report

Base: 73.35% // Head: 73.74% // Increases project coverage by +0.38% 🎉

Coverage data is based on head (0ee0d8e) compared to base (1195ceb).
Patch coverage: 72.67% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   73.35%   73.74%   +0.38%     
==========================================
  Files          12       12              
  Lines        1524     1691     +167     
==========================================
+ Hits         1118     1247     +129     
- Misses        406      444      +38

Impacted Files	Coverage Δ
src/DAT/dciterators.jl	`82.02% <ø> (-0.20%)`	⬇️
src/YAXArrays.jl	`50.00% <ø> (-25.00%)`	⬇️
src/YAXTools.jl	`96.07% <ø> (+1.63%)`	⬆️
src/DAT/DAT.jl	`74.63% <66.66%> (-1.60%)`	⬇️
src/DatasetAPI/Datasets.jl	`74.71% <67.82%> (+3.66%)`	⬆️
src/Cubes/Cubes.jl	`89.74% <83.33%> (-1.37%)`	⬇️
src/Cubes/Rechunker.jl	`91.83% <91.83%> (ø)`
src/Cubes/TransformedCubes.jl	`78.78% <100.00%> (+3.78%)`	⬆️
src/Cubes/Axes.jl	`81.11% <0.00%> (-1.49%)`	⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coveralls · 2022-07-07T14:19:59Z

Pull Request Test Coverage Report for Build 2875995948

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

274 of 377 (72.68%) changed or added relevant lines in 5 files are covered.
15 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.5%) to 73.743%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/DAT/DAT.jl	2	3	66.67%
src/Cubes/Rechunker.jl	45	49	91.84%
src/Cubes/Cubes.jl	25	30	83.33%
src/DatasetAPI/Datasets.jl	196	289	67.82%

Files with Coverage Reduction	New Missed Lines	%
src/DatasetAPI/Datasets.jl	1	74.72%
src/YAXArrays.jl	4	50.0%
src/DAT/DAT.jl	10	74.63%

Totals
Change from base Build 2614664627:	0.5%
Covered Lines:	1247
Relevant Lines:	1691

💛 - Coveralls

github-actions · 2022-07-20T09:06:47Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmarks:
- Target: 20 Jul 2022 - 09:05
- Baseline: 20 Jul 2022 - 09:06
Package commits:
- Target: a1c26e
- Baseline: 923e04
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["mapslices", "small"]`	0.02 (5%) ✅	0.18 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.15.0-1014-azure #17~20.04.1-Ubuntu SMP Thu Jun 23 20:01:51 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1506 s          2 s        248 s        492 s          0 s
       #2  2294 MHz       1024 s          1 s        231 s       1015 s          0 s
       
  Memory: 6.780967712402344 GB (2543.7109375 MB free)
  Uptime: 233.25 sec
  Load Avg:  2.06  1.67  0.74
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.15.0-1014-azure #17~20.04.1-Ubuntu SMP Thu Jun 23 20:01:51 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1656 s          2 s        258 s        816 s          0 s
       #2  2294 MHz       1352 s          1 s        243 s       1162 s          0 s
       
  Memory: 6.780967712402344 GB (2703.30859375 MB free)
  Uptime: 282.19 sec
  Load Avg:  1.46  1.57  0.75
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Target result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmark: 20 Jul 2022 - 9:5
Package commit: a1c26e
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["mapslices", "small"]`	256.843 ms (5%)	8.145 ms	325.11 MiB (1%)	41579

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.15.0-1014-azure #17~20.04.1-Ubuntu SMP Thu Jun 23 20:01:51 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1506 s          2 s        248 s        492 s          0 s
       #2  2294 MHz       1024 s          1 s        231 s       1015 s          0 s
       
  Memory: 6.780967712402344 GB (2543.7109375 MB free)
  Uptime: 233.25 sec
  Load Avg:  2.06  1.67  0.74
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Baseline result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Time of benchmark: 20 Jul 2022 - 9:6
Package commit: 923e04
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["mapslices", "small"]`	16.378 s (5%)	985.093 ms	1.73 GiB (1%)	27578166

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["mapslices"]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.4 LTS
  uname: Linux 5.15.0-1014-azure #17~20.04.1-Ubuntu SMP Thu Jun 23 20:01:51 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz: 
              speed         user         nice          sys         idle          irq
       #1  2294 MHz       1656 s          2 s        258 s        816 s          0 s
       #2  2294 MHz       1352 s          1 s        243 s       1162 s          0 s
       
  Memory: 6.780967712402344 GB (2703.30859375 MB free)
  Uptime: 282.19 sec
  Load Avg:  1.46  1.57  0.75
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, broadwell)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           79
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Stepping:                        1
CPU MHz:                         2294.686
BogoMIPS:                        4589.37
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        50 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
Vendor	:Intel
Architecture	:Broadwell
Model	Family: 0x06, Model: 0x4f, Stepping: 0x01, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 51200) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

meggart · 2022-07-22T16:08:33Z

I have fixed a few things related to missing values so that it should be possible to load saved cubes again. Whoever wants to test this @felixcremer @lazarusA @mweynants you can get the current branch running in a fresh environment with
]add YAXArrays#newbettersaving EarthDataLab#master YAXArrayBase#master

I am off for vacation now, but please feel free to post issues and comments for the branch here.

meggart · 2022-08-17T08:41:15Z

In principle I would like to merge this. However, I think @felixcremer was preparing a review with a lot of comments. Do you have some kind of timeline here?

docs/src/examples/Saving and rechunking.md

Project.toml

docs/src/examples/Saving and rechunking.md

src/Cubes/Rechunker.jl

src/Cubes/TransformedCubes.jl

Co-authored-by: Felix Cremer <[email protected]>

docs/src/examples/Saving and rechunking.md

Co-authored-by: Felix Cremer <[email protected]>

src/Cubes/Cubes.jl

src/Cubes/Rechunker.jl

Co-authored-by: Felix Cremer <[email protected]>

I also removed the skeleton keyword from the append_dataset function, because it haven't been used in the function body and I don't see the use case.

felixcremer

I think, that I fixed all things, that we discussed yesterday.
@meggart I still have one question:
What is the use case for an append_dataset skeleton and should the keyword get a default value. Because currently the skeleton keyword argument is not used in the append_dataset function.
Apart from that I think this PR is now good to go.

src/DatasetAPI/Datasets.jl

felixcremer · 2022-08-19T09:38:29Z

I just started the registration process. So this should be available soon.

meggart and others added 14 commits June 3, 2022 08:41

First iteration of new savedataset

167e3d2

New model to save cubes

86cbd22

Add some saving examples

d9b2892

More docs

e81ea39

Even more examples

e73767a

All tests pass

191165e

Add save tests

8ff1027

Bug in test

83a191d

Fixing test

c1c0556

Penalize buffers larger than the dimlength

8225d1f

We want, that the buffersize is at most the length along the given dimension. Therefore we are penalizing buffers which are larger than the dimension length. This also surfaces the writefac parameter to the savecube function.

Add docs for savecube function

06c9c3e

fix

5f8be60

fix bugs

41010e6

remove loadorgenerate for now

2d8bdef

felixcremer mentioned this pull request Jul 19, 2022

Revamp of Dataset and YAXArray saving #132

Closed

Never allow missing when writing data

eb9da50

meggart and others added 3 commits July 20, 2022 13:30

Bunp YAXArrayBase version

362335c

fix missings

6f2965c

Fix tests

d09772f

felixcremer mentioned this pull request Jul 27, 2022

Improve documentation #153

Closed

meggart added 2 commits August 16, 2022 08:58

Remove unnecessary show statements

0b512b6

Require YAXArrayBase 0.6

e79bc8e

felixcremer requested changes Aug 17, 2022

View reviewed changes

felixcremer reviewed Aug 17, 2022

View reviewed changes

src/Cubes/TransformedCubes.jl Show resolved Hide resolved

meggart and others added 2 commits August 17, 2022 16:13

Update docs/src/examples/Saving and rechunking.md

ff383f3

Co-authored-by: Felix Cremer <[email protected]>

Update docs/src/examples/Saving and rechunking.md

bdf7e39

Co-authored-by: Felix Cremer <[email protected]>

meggart commented Aug 17, 2022

View reviewed changes

docs/src/examples/Saving and rechunking.md Outdated Show resolved Hide resolved

meggart and others added 3 commits August 17, 2022 16:16

Update docs/src/examples/Saving and rechunking.md

4ef9baa

Update docs/src/examples/Saving and rechunking.md

d153278

Co-authored-by: Felix Cremer <[email protected]>

Update docs/src/examples/Saving and rechunking.md

d816b19

Co-authored-by: Felix Cremer <[email protected]>

meggart commented Aug 17, 2022

View reviewed changes

src/Cubes/Cubes.jl Outdated Show resolved Hide resolved

Update src/Cubes/Cubes.jl

e84162e

meggart commented Aug 17, 2022

View reviewed changes

src/Cubes/Cubes.jl Outdated Show resolved Hide resolved

Update src/Cubes/Cubes.jl

85b3ca8

meggart commented Aug 17, 2022

View reviewed changes

src/Cubes/Rechunker.jl Outdated Show resolved Hide resolved

meggart and others added 10 commits August 17, 2022 16:26

Update src/Cubes/Rechunker.jl

bb8469c

Update src/Cubes/Rechunker.jl

7b30831

Co-authored-by: Felix Cremer <[email protected]>

Update src/Cubes/Rechunker.jl

9ab251e

Co-authored-by: Felix Cremer <[email protected]>

Rename the skeleton_only keyword to skeleton

54d604d

I also removed the skeleton keyword from the append_dataset function, because it haven't been used in the function body and I don't see the use case.

Put the skeleton keyword back into append_dataset

b598825

Use eachchunk(c) instead of c.chunks

7ef3bb8

Use the max_cache from YAXDefaults in the Rechunker scripts

b1aba71

Switch to explicit using for ProgressMeter

c0adda1

Add test for non-missing append_dataset

b317239

Fully remove lines related to @loadorgenerate

24ef5ed

felixcremer approved these changes Aug 18, 2022

View reviewed changes

meggart commented Aug 19, 2022

View reviewed changes

src/DatasetAPI/Datasets.jl Outdated Show resolved Hide resolved

Update src/DatasetAPI/Datasets.jl

a34b149

meggart commented Aug 19, 2022

View reviewed changes

src/DatasetAPI/Datasets.jl Outdated Show resolved Hide resolved

Update src/DatasetAPI/Datasets.jl

0ee0d8e

meggart merged commit 8ce45d2 into master Aug 19, 2022

felixcremer mentioned this pull request Jan 13, 2023

savecube does not take backend kwargs anymore #215

Closed

lazarusA deleted the newbettersaving branch August 22, 2023 15:13

Newbettersaving #150

Newbettersaving #150

Conversation

meggart commented Jul 7, 2022

github-actions bot commented Jul 7, 2022

Judge result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

codecov bot commented Jul 7, 2022 • edited Loading

Codecov Report

coveralls commented Jul 7, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2875995948

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

github-actions bot commented Jul 20, 2022

Judge result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/YAXArrays.jl/YAXArrays.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

meggart commented Jul 22, 2022

meggart commented Aug 17, 2022

felixcremer left a comment

Choose a reason for hiding this comment

felixcremer commented Aug 19, 2022

codecov bot commented Jul 7, 2022 •

edited

Loading

coveralls commented Jul 7, 2022 •

edited

Loading