-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to fix typo #91
Conversation
This is just a super confusing docstring. The Might be best to remove that altogether... |
How about this change instead? |
Makes sense to me. Wanna reflect the same change in the docstring as well? |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 1 1
Lines 383 383
=======================================
Hits 284 284
Misses 99 99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think it might be better in the docstring to use a @infiltrate
@infiltrate condition::Bool Thoughts? |
Makes sense to me. |
5b4bf23
to
23fb8fa
Compare
This commit also fixes some whitespace changes in the README
I did a rebase on top of the latest README in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is the current README's example:
But I think this is what it should be: