investigate segfaults on CI

[simeonschaub]

The segfaults on CI seem to point to these two tests in particular.
Let's see if disabling them fixes CI or whether that might have just
been a red herring

[codecov]

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (7beca92) 86.54% compared to head (6070f13) 82.26%.

Files	Patch %	Lines
src/builtins.jl	11.25%	71 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   86.54%   82.26%   -4.29%     
==========================================
  Files          12       12              
  Lines        2542     2458      -84     
==========================================
- Hits         2200     2022     -178     
- Misses        342      436      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[simeonschaub]

Well, that certainly answers the question... 😅

[aviatesk]

😱

[simeonschaub]

Hmm, at least nightly doesn't segfault anymore, the tests just fail... 🤔

[aviatesk]

How would you like to proceed with this issue? I'm of the view that for healthy development, it's acceptable to disable tests that are challenging to correct at the moment. My preference is to focus on restoring the CI as a first step.

[simeonschaub]

Yeah, unfortunately this PR showed that the issues ran deeper than just a single failing test. Wondering wether the segfaults might have to do with #591?

[aviatesk]

Yeah, I will take a look on it later today.