Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JuliaSyntax says public as an identifier is deprecated #612

Merged
merged 1 commit into from
Jun 14, 2024
Merged

JuliaSyntax says public as an identifier is deprecated #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/construct.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ In a fresh session,

```
julia> expr = quote
public(x::Integer) = true
public_fn(x::Integer) = true
module Private
private(y::String) = false
end
Expand All @@ -365,7 +365,7 @@ julia> for (mod, ex) in ExprSplitter(Main, expr)
mod = Main
ex = quote
#= REPL[7]:2 =#
public(x::Integer) = begin
public_fn(x::Integer) = begin
#= REPL[7]:2 =#
true
end
Expand Down Expand Up @@ -415,7 +415,7 @@ julia> for (mod, ex) in ExprSplitter(Main, expr)
julia> threshold
0.1

julia> public(3)
julia> public_fn(3)
true
```

Expand Down
4 changes: 2 additions & 2 deletions src/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
module var"#Internal"
public(x::String) = false
public_fn(x::String) = false

Check warning on line 2 in src/precompile.jl

View check run for this annotation

Codecov / codecov/patch

src/precompile.jl#L2 

Added line #L2 was not covered by tests
end

function _precompile_()
ccall(:jl_generating_output, Cint, ()) == 1 || return nothing
@interpret sum(rand(10))
expr = quote
public(x::Integer) = true
public_fn(x::Integer) = true

Check warning on line 9 in src/precompile.jl

View check run for this annotation

Codecov / codecov/patch

src/precompile.jl#L9 

Added line #L9 was not covered by tests
module Private
private(y::String) = false
end
Expand Down
Loading