Add static tests with JET #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 88.97% 92.87% +3.90%
==========================================
Files 19 21 +2
Lines 408 519 +111
==========================================
+ Hits 363 482 +119
+ Misses 45 37 -8
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JET.jl enables static testing of code correctness, it's good to catch typos among other things. We could also use it to test for dynamic dispatch (although I'm sure the Frank-Wolfe part is ripe with it)
I had to remove the generic methods throwing errors, and replace them with empty functions. It's better style anyway.
However, this leads JET to assume that no method exists for
compute_maximizer(base_loss, θ, α, y_true)in the SSVM. As a result, I switched the analysis to:typomode for now instead of the more complete version. I opened an issue to keep track of this: aviatesk/JET.jl#495Tests might fail on Julia 1.10 because of a bug in Zygote: FluxML/Zygote.jl#1410