Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated Vararg UnionAll outside #493

Merged
merged 3 commits into from
Oct 16, 2021
Merged

Move deprecated Vararg UnionAll outside #493

merged 3 commits into from
Oct 16, 2021

Conversation

oxinabox
Copy link
Member

Closes #492.
This should fix julia 1.7

src/projection.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2021

Codecov Report

Merging #493 (7255e78) into main (38c4089) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files          15       15           
  Lines         822      822           
=======================================
  Hits          764      764           
  Misses         58       58           
Impacted Files Coverage Δ
src/projection.jl 97.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c4089...7255e78. Read the comment docs.

@mcabbott
Copy link
Member

This is narrower than before, although I doubt it matters:

julia> _PZ_Tuple = Tuple{_PZ,Vararg{<:_PZ}}; # old

julia> (ProjectTo{NoTangent}(), ProjectTo{ZeroTangent}()) isa _PZ_Tuple
true

julia> _PZ_Tuple2 = Tuple{PZ,Vararg{PZ}} where PZ<:_PZ # new
Tuple{PZ, Vararg{PZ}} where PZ<:(ProjectTo{<:AbstractZero})

julia> (ProjectTo{NoTangent}(), ProjectTo{ZeroTangent}()) isa _PZ_Tuple2
false

julia> ProjectTo(false)
ProjectTo{NoTangent}()

We could also consider ripping out all these <:AbstractZero and replacing them with ProjectTo{NoTangent} exactly. Or one step further, with Returns{NoTangent}.

src/projection.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oxinabox
Copy link
Member Author

We could also consider ripping out all these <:AbstractZero and replacing them with ProjectTo{NoTangent} exactly. Or one step further, with Returns{NoTangent}.

Maybe. Out of scope for this PR

src/projection.jl Outdated Show resolved Hide resolved
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxinabox oxinabox merged commit 59948e5 into main Oct 16, 2021
@oxinabox oxinabox deleted the ox/union_alloutside branch October 16, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dep/failure on v1.7
4 participants