Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DifferentiateWith compatible with ForwardDiff, clarify docs #487

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 23, 2024

DIT source

  • Clarify documentation of DifferentiateWith, mention compositions.

DIT extensions

  • Make DifferentiateWith compatible with ForwardDiff through Dual and AbstractArray{<:Dual} overloads

DI tests

  • Test DifferentiateWith for Zygote and ForwardDiff on the closurified backends, using FiniteDiff as substitute

@gdalle gdalle changed the title Make DIfferentiateWith compatible with ForwardDiff, clarify docs Make DifferentiateWith compatible with ForwardDiff, clarify docs Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (5750b31) to head (604e067).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
- Coverage   98.51%   97.84%   -0.67%     
==========================================
  Files         107      107              
  Lines        4298     4311      +13     
==========================================
- Hits         4234     4218      -16     
- Misses         64       93      +29     
Flag Coverage Δ
DI 98.31% <100.00%> (-0.27%) ⬇️
DIT 96.88% <ø> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 1369010 into main Sep 23, 2024
58 checks passed
@gdalle gdalle deleted the gd/differentiatewith branch September 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DifferentiateWith for ForwardDiff Better docs for DifferentiateWith
3 participants