-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on new Bulma-based front end #1091
Comments
@mortenpi - a fantastic achievement. Thank you. I have noticed one small thing - I am not sure if it is intended. Here are the steps to replicate it:
The effect is that "julia" also becomes dark. It seems that the theme is a global variable across tabs (at least on Chrome). I expected it to be tab-local, but maybe this is intended? |
It's global for a domain, and sort of intentional (I am just using a But it might make sense to make it local to a specific package by storing a separate value for every document root.. it might become especially relevant when people actually start deploying custom themes. OTOH, a nice feature of the current approach is that when you browse e.g. pkg.julialang.org (or any org. that hosts several packages), your theme preference will be shared by all the packages. |
I agree that the approach has its merits (that is why I just wanted to make sure this is intended, as it was somewhat surprising). Another small issue: in new theme a code without link and code with link are rendered in exactly the same way. So it is hard to know which parts of the text have links (in the old theme it was clear). Take a look e.g. at https://mortenpi.eu/gsoc2019-mockups/bulma/v13/julia/manual/strings/#. |
Nice, this looks much better, especially the new cards for the standard library methods and the syntax highlighting! A few comments:
Keep up the good work! |
Hi, thanks for your work. From my perspective, here are comments:
|
My comments:
|
This is to track smaller issues with and feedback on the new front end (#1043). These would be good to fix before releasing Documenter 0.24.
The latest Julia manual build with the new front end is available here (Aug 11).
Blockers for 0.24.0:
Other potential enhancements:
The text was updated successfully, but these errors were encountered: