Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: New manual front end #32839

Merged
merged 9 commits into from
Nov 25, 2019
Merged

RFC: New manual front end #32839

merged 9 commits into from
Nov 25, 2019

Conversation

mortenpi
Copy link
Contributor

@mortenpi mortenpi commented Aug 9, 2019 •
edited
Loading

Just a preliminary RFC with the new manual front end. Here is the latest demo:

https://mortenpi.eu/gsoc2019-mockups/bulma/v16/

Other than bumping Documenter (to a branch version currently), it also swaps out the logo for an SVG version (PNG currently). And as the new front end supports a dark theme, we actually need two variants of the logo.

Ref: JuliaDocs/Documenter.jl#1091, JuliaDocs/Documenter.jl#1043

  • Compat admonition styling
  • Documenter 0.24.0 release
  • Update doc/Manifest.toml to use a released Documenter version

@vchuravy
Copy link
Member

vchuravy commented Aug 9, 2019

Uh! This looks good. Only comment I had is that versions are rendered without a dot e.g. v12 instead of v1.2 in the version selector and the urls (http://mortenpi.eu/gsoc2019-mockups/bulma/v12/manual/mathematical-operations/)

@bicycle1885
Copy link
Member

Looks really cool! Let me leave a comment. The red code color looks a little bit too vivid to my eyes. How about making it slightly darker?

@mortenpi
Copy link
Contributor Author

@vchuravy The versions there are actually the versions of the front end, and not of Julia.

Played around a bit more with the colors and a few other things -- new version here: https://mortenpi.eu/gsoc2019-mockups/bulma/v13/julia/

@carstenbauer
Copy link
Member

I love it! Looks really fresh. And the ability to fold navigation submenus is very much appreciated! As a side comment, maybe it's just me but I feel the color for inline code (darkish red) and those for the highlight boxes (very vivid blue/yellow etc) clash a tiny bit. Not by much but still noticeable. I don't want to be nitpicky but just wanted to leave it as a comment. Again, awesome work!

@mbauman
Copy link
Member

mbauman commented Aug 13, 2019

This is great! Just one small (subpixel) nit: this appears to disable subpixel font rendering on (at least) macOS/Chrome. With my old non-retina screen, it makes things look pretty crummy. Compare:

Screen Shot 2019-08-13 at 12 36 08 PM

The old is on the left and the new is on the right — note the blue and red shading on the left but not on the right.

@mortenpi
Copy link
Contributor Author

Hmm, it seems to be fine on Ubuntu / Chrome 76?

subpixel

Interestingly, unlike in the original manual, Bulma actually sets -webkit-font-smoothing: antialiased;, which is what should enable this. Although, there is also -webkit-font-smoothing: subpixel-antialiased;?

@mbauman Could you go in with developer tools and try changing -webkit-font-smoothing on the <html> element, to see what happens if you (1) disable it altogether (equivalent to old style if I am not mistaken), and (2) set it to -webkit-font-smoothing: subpixel-antialiased? On my system is does not seem to make any difference though.

@mbauman
Copy link
Member

mbauman commented Aug 16, 2019

That does the trick! Also removing that property entirely also gets it rendering with subpixel antialiasing.

@mortenpi mortenpi mentioned this pull request Aug 18, 2019
Closed
6 tasks
@mortenpi
Copy link
Contributor Author

Superseded by #33922

@mortenpi mortenpi closed this Nov 23, 2019
@mortenpi mortenpi deleted the bulma branch November 23, 2019 08:28
@mortenpi mortenpi restored the bulma branch November 23, 2019 08:29
@mortenpi
Copy link
Contributor Author

Actually, no. #33922 was missing some updates necessary for the new front end.

@mortenpi mortenpi reopened this Nov 23, 2019
@mortenpi mortenpi marked this pull request as ready for review November 25, 2019 09:58
@mortenpi
Copy link
Contributor Author

This is good to go now. Latest demo available here. Also bumps Documenter to 0.24.1 to fix a PDF building bug.

@fredrikekre fredrikekre merged commit 764ff06 into JuliaLang:master Nov 25, 2019
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@mortenpi @KristofferC
Documenter: Tweaks for the new frontend and update to 0.24.1 (#32839)
62ef597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mortenpi @vchuravy @bicycle1885 @carstenbauer @mbauman @fredrikekre